Add security-rules-auditor subagent#88
Open
joehan wants to merge 1 commit intofirebase:mainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new agent configuration, security-rules-auditor.md, designed to audit Firestore security rules for vulnerabilities. The review feedback identifies that the firestore-security-rules-auditor skill is missing from the tools list despite being required by the system prompt.
Comment on lines
+5
to
+7
| tools: | ||
| - read_file | ||
| - grep_search |
Contributor
There was a problem hiding this comment.
The system prompt (line 13) explicitly directs the agent to use the firestore-security-rules-auditor skill. However, this skill is not listed in the tools section. In this agent framework, skills intended for use by an agent must be explicitly declared as tools to be accessible during execution.
Suggested change
| tools: | |
| - read_file | |
| - grep_search | |
| tools: | |
| - read_file | |
| - grep_search | |
| - firestore-security-rules-auditor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the security-rules-auditor subagent.