Skip to content

Fix skill name mismatches in metadata#93

Merged
joehan merged 2 commits intomainfrom
fix-skill-name-mismatches
Apr 27, 2026
Merged

Fix skill name mismatches in metadata#93
joehan merged 2 commits intomainfrom
fix-skill-name-mismatches

Conversation

@joehan
Copy link
Copy Markdown
Member

@joehan joehan commented Apr 22, 2026

This PR fixes the skill name mismatches in metadata for firebase-security-rules-auditor and firebase-ai-logic-basics to match their folder names.

I went with firebase-security-rules-auditor over firestore-security-rules-auditor so that we can extend this skill in the future if we want without a full rename

TAG=agy
CONV=e2895221-778b-4959-b3b9-a264dd7a9405

joehan added 2 commits April 22, 2026 10:44
The skill name in metadata was 'firestore-security-rules-auditor' while the folder name was 'firebase-security-rules-auditor'.

TAG=agy

CONV=e2895221-778b-4959-b3b9-a264dd7a9405
The skill name in metadata was 'firebase-ai-logic' while the folder name was 'firebase-ai-logic-basics'.

TAG=agy

CONV=e2895221-778b-4959-b3b9-a264dd7a9405
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the skill names in the metadata for the Firebase AI Logic and Security Rules Auditor skills to improve naming consistency. I have no feedback to provide as there were no review comments to evaluate.

@joehan joehan requested a review from maneesht April 22, 2026 20:43
@ahamedjobayer081-spec
Copy link
Copy Markdown

This PR fixes the skill name mismatches in metadata for firebase-security-rules-auditor and firebase-ai-logic-basics to match their folder names.

I went with firebase-security-rules-auditor over firestore-security-rules-auditor so that we can extend this skill in the future if we want without a full rename

TAG=agy CONV=e2895221-778b-4959-b3b9-a264dd7a9405

@ahamedjobayer081-spec
Copy link
Copy Markdown

Code Review

This pull request updates the skill names in the metadata for the Firebase AI Logic and Security Rules Auditor skills to improve naming consistency. I have no feedback to provide as there were no review comments to evaluate.

@ahamedjobayer081-spec
Copy link
Copy Markdown

#80

Copy link
Copy Markdown

@ahamedjobayer081-spec ahamedjobayer081-spec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

@joehan joehan merged commit 1a5c449 into main Apr 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants