Skip to content

refactor: improve partitioning code #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cabljac merged 3 commits into from
Jan 26, 2026
Merged

refactor: improve partitioning code #2447

cabljac merged 3 commits into from
Jan 26, 2026

Conversation

@cabljac
Copy link
Contributor

@cabljac cabljac commented Jun 12, 2025 •
edited
Loading

This PR refactors partitioning code and tests.

  • splits partitioning.ts into a more modular and type-safe structure that is easier to reason about
  • bumps by a major version as the public API of the changetracker package has breaking but necessary changes.

@cabljac cabljac force-pushed the @invertase/fix-partitioning-2 branch from b2060ac to c2e01b4 Compare June 12, 2025 14:55
@cabljac cabljac requested a review from CorieW July 1, 2025 15:05
@cabljac cabljac marked this pull request as ready for review July 1, 2025 15:05
@cabljac cabljac requested a review from a team as a code owner July 1, 2025 15:05
@cabljac cabljac mentioned this pull request Jul 2, 2025
Open
CorieW
CorieW approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@CorieW CorieW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like, LGTM.

Additionally, it would be nice to have tests for each partition type, but probably in a different PR.

@cabljac cabljac force-pushed the @invertase/fix-partitioning-2 branch from c2e01b4 to 2173383 Compare July 16, 2025 08:44
@cabljac cabljac mentioned this pull request Sep 11, 2025
Open
@cabljac cabljac force-pushed the @invertase/fix-partitioning-2 branch from d87fc0d to 14b2680 Compare January 26, 2026 13:58
@cabljac cabljac merged commit 442722a into next Jan 26, 2026
7 checks passed
@cabljac cabljac deleted the @invertase/fix-partitioning-2 branch January 26, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CorieW CorieW CorieW approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cabljac @CorieW