Skip to content

fix: allow '/' characters in Firestore map keys#176

Open
demolaf wants to merge 2 commits intomainfrom
fix-issue-83
Open

fix: allow '/' characters in Firestore map keys#176
demolaf wants to merge 2 commits intomainfrom
fix-issue-83

Conversation

@demolaf
Copy link
Copy Markdown
Member

@demolaf demolaf commented Feb 23, 2026

Map keys were incorrectly routed through field-path validation which rejects / characters, causing an ArgumentError when storing keys like products/product-a.

Fixes #83

@demolaf demolaf marked this pull request as draft February 23, 2026 16:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2026

Coverage Report

✅ Coverage 74.56% meets 40% threshold

Total Coverage: 74.56%
Lines Covered: 5015/6726

Package Breakdown

Package Coverage
dart_firebase_admin 72.42%
google_cloud_firestore 76.99%

Minimum threshold: 40%

@demolaf demolaf marked this pull request as ready for review February 25, 2026 09:23
@demolaf demolaf linked an issue Feb 27, 2026 that may be closed by this pull request
Base automatically changed from next to main March 18, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firestore map keys considered invalid when containing / characters

2 participants