Merged
Conversation
Collaborator
kevmoo
commented
Apr 10, 2026
kevmoo
commented
- move script to scripts dir
- only generate for dart_firebase_admin
- put it in the lib/src directory
- move script to scripts dir - only generate for dart_firebase_admin - put it in the lib/src directory
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the version generation script to a dedicated scripts directory and refactors it to target the dart_firebase_admin package specifically, shifting the output location of the generated version file to lib/src. Corresponding import updates were made in the application and test code to reflect this new structure. Review feedback focused on updating the script's internal documentation and generated headers to match the new file paths, as well as improving the robustness of the version extraction logic to correctly handle potential trailing comments in the pubspec file.
Coverage Report✅ Coverage 74.56% meets 40% threshold Total Coverage: 74.56% Package Breakdown
Minimum threshold: 40% |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
demolaf
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.