feat(app): allow configuring firestore instance id#631
Open
aexvir wants to merge 1 commit intofirebase:devfrom
Open
feat(app): allow configuring firestore instance id#631aexvir wants to merge 1 commit intofirebase:devfrom
aexvir wants to merge 1 commit intofirebase:devfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
64b25f7 to
984a7b3
Compare
vksssd
approved these changes
Jun 21, 2024
vksssd
approved these changes
Jun 21, 2024
vksssd
approved these changes
Jun 21, 2024
vksssd
approved these changes
Jul 5, 2024
Author
|
@lahirumaramba sorry for the ping, do you think someone could review this anytime soon? |
9d1e45d to
c8857c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋🏻 hey there
I'm trying to use the firebase sdk for my app but I'm not using the default
(default)firestore db instance, which seems to be the only supported option by this sdkthis mr introduces a new option,
firestoreIDconfigurable like the others, via json or via explicit values in theConfigstruct, and passes this value to theNewClientWithDatabasefirestore constructorif no value is supplied, the default db is still targeted, so this shouldn't incur any breaking change to existing users, moreover, there's no hardcoded values, I'm using the public variable exposed by the firestore package
I've also updated the tests to not only verify that the constructor succeeds, but also that the correct database is being used when e.g. building document refs