Fix (#688): Updated JSON tag for ChannelID field in AndroidConfig.Notification#693
Open
Surya-7890 wants to merge 1 commit intofirebase:masterfrom
Open
Fix (#688): Updated JSON tag for ChannelID field in AndroidConfig.Notification#693Surya-7890 wants to merge 1 commit intofirebase:masterfrom
Surya-7890 wants to merge 1 commit intofirebase:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the try it out example in , we can see that the
channelIdfield inandroid.notificationis in camel case,{ message: { android: { notification: { channelId: "" } } } }While in the SDK, the json tag for that field is set to the following
FIx:
Modified the occurances of this fields
firebase-admin-go/messaging/messaging.go
Line 180 in 570427a
and
firebase-admin-go/messaging/messaging_test.go
Line 227 in 570427a