feat: expose Firebase error information to SDK users#728
Open
putcho01 wants to merge 1 commit intofirebase:masterfrom
Open
feat: expose Firebase error information to SDK users#728putcho01 wants to merge 1 commit intofirebase:masterfrom
putcho01 wants to merge 1 commit intofirebase:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
This PR exposes Firebase error information to SDK users by making error codes and details publicly accessible through the
errorutilspackage.Previously, SDK users could only check for specific error conditions using boolean helper functions (e.g.,
IsNotFound(),messaging.IsUnregistered()). They had no programmatic access to the underlying error codes or Firebase-specific error details stored in the internalExtmap.This PR introduces a public
FirebaseErrortype andAsFirebaseError()function that allows users to:INVALID_ARGUMENT,NOT_FOUND)UNREGISTERED,QUOTA_EXCEEDEDfor FCM,USER_NOT_FOUNDfor Auth)Motivation
Users need to distinguish between different types of Firebase errors to take appropriate actions. For example:
UNREGISTERED, the device token should be removed from the databaseQUOTA_EXCEEDED, the application should implement backoff/retry logicID_TOKEN_EXPIRED, the user should be prompted to re-authenticateWithout programmatic access to these error codes, users must rely on ~30+ boolean helper functions scattered across different packages, making it difficult to write maintainable error handling code.
Testing
Notes