Fix: Update the log callback to use int32 instead of enum in dll

[AustinBenoit]

The call to the dll will still leverage the enum.
This should ensure ABI stability over time

Description

Provide details of the change, and generalize the change in the PR title above.
Fix: Update the log callback to use int32 instead of enum in dll

---

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Leverage the existing log callback integration test

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

Notes

• Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
• Read the contribution guidelines CONTRIBUTING.md.
• Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

[gemini-code-assist]

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Analytics SDK by improving the Application Binary Interface (ABI) stability of its log callback mechanism, transitioning the log level parameter from an enum to a fixed-size integer type. Concurrently, it introduces a new feature that enables configuration of the session timeout duration, offering greater flexibility in managing user sessions. The changes also include an update to the list of known DLL hashes, reflecting an update to the underlying Analytics library.

Highlights

• Log Callback ABI Stability: The GoogleAnalytics_LogCallback function pointer type has been updated to use int32_t instead of the GoogleAnalytics_LogLevel enum for its log_level parameter. This change is specifically implemented to ensure Application Binary Interface (ABI) stability across different compilers and versions, preventing potential compatibility issues.
• Internal Log Callback Adaptation: The internal GoogleAnalyticsWrapperLogCallback now accepts int32_t for the log_level parameter and explicitly casts it back to GoogleAnalytics_LogLevel before processing, maintaining internal logic while adhering to the new ABI-stable signature.
• New Session Timeout Feature: A new session_timeout_duration_seconds field has been added to the GoogleAnalytics_Options and Analytics::Options structs, allowing users to configure the duration of inactivity after which an Analytics session terminates. This provides more granular control over session management.
• Public API for Session Timeout: A new public API function, GoogleAnalytics_SetSessionTimeoutInterval, along with its C++ wrapper Analytics::SetSessionTimeoutInterval, has been introduced. This allows programmatic setting of the session timeout duration.
• DLL Hash Update: A new SHA256 hash has been added to the list of known Google Analytics Windows DLL hashes, and the corresponding count has been incremented. This update likely reflects a new version or build of the underlying Google Analytics Windows DLL.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

✅  Integration test succeeded!

Requested by @AustinBenoit on commit 4e9e85a
Last updated: Fri Jan 16 09:18 PST 2026
View integration test log & download artifacts

[gemini-code-assist]

Code Review

This pull request aims to improve ABI stability by using int32_t instead of enums in the DLL interface, which is a commendable practice. It also introduces a new feature for configuring session timeout duration. While the changes for ABI stability are correctly implemented in the C++ wrappers, the pull request appears to be incomplete. The dynamic stub files for the Windows DLL have not been updated to reflect the changes in the C API header, which will lead to build failures or runtime errors for the new and modified functions. Additionally, there is a minor opportunity to enhance maintainability by dynamically calculating an array size instead of hardcoding it.

[gemini-code-assist]

To improve maintainability and prevent potential mismatches in the future, it's better to calculate the number of hashes dynamically rather than hardcoding it. This ensures that the count is always in sync with the number of elements in the FirebaseAnalytics_KnownWindowsDllHashes array.

Suggested change

	const int FirebaseAnalytics_KnownWindowsDllHashCount = 5;
	const int FirebaseAnalytics_KnownWindowsDllHashCount = sizeof(FirebaseAnalytics_KnownWindowsDllHashes) / sizeof(FirebaseAnalytics_KnownWindowsDllHashes[0]);