Add onCallGenkit extension#126
Open
mosuem wants to merge 21 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the firebase_functions_genkit package, which provides an extension to integrate Genkit flows with Firebase Functions, supporting both streaming and non-streaming callable requests. The review feedback identifies critical issues regarding type safety and asynchronous execution, specifically the need for a generic Input type in onCallGenkit, missing await statements on Future results, and syntax errors in the example's schema definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add https://firebase.google.com/docs/reference/functions/2nd-gen/node/firebase-functions.https#httpsoncallgenkit
Re-opening of #26