Skip to content

Add onCallGenkit extension#126

Open
mosuem wants to merge 21 commits into
firebase:mainfrom
mosuem:addOnCallGenkit
Open

Add onCallGenkit extension#126
mosuem wants to merge 21 commits into
firebase:mainfrom
mosuem:addOnCallGenkit

Conversation

@mosuem

@mosuem mosuem commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

@mosuem mosuem changed the title Add on call genkit Add onCallGenkit extension Apr 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the firebase_functions_genkit package, which provides an extension to integrate Genkit flows with Firebase Functions, supporting both streaming and non-streaming callable requests. The review feedback identifies critical issues regarding type safety and asynchronous execution, specifically the need for a generic Input type in onCallGenkit, missing await statements on Future results, and syntax errors in the example's schema definitions.

Comment thread firebase_functions_genkit/example/bin/example.dart
Comment thread firebase_functions_genkit/example/bin/example.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant