Conversation
Summary of ChangesHello @aalej, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully implements the --open flag for the hosting:channel:deploy command, allowing users to automatically open the deployed channel URLs in their default browser. The implementation correctly handles non-interactive environments. My feedback focuses on adhering to the repository's style guide by using existing utility functions and ensuring that asynchronous operations are properly awaited to avoid potential race conditions during process exit.
| import { requireHostingSite } from "../requireHostingSite"; | ||
| import { HostingOptions } from "../hosting/options"; | ||
| import { Options } from "../options"; | ||
| import * as opn from "open"; |
There was a problem hiding this comment.
This import introduces a direct dependency on the open package, which is already wrapped by the openInBrowser utility in src/utils.ts. According to the repository style guide, existing utilities should be used whenever possible. Please remove this import and add openInBrowser to the existing import from ../utils on line 20.
References
- Look for existing utilities first: Before writing common helper functions (e.g., for logging, file system operations, promises, string manipulation), check
src/utils.tsto see if a suitable function already exists. (link)
|
|
||
| if (options.open && !options.nonInteractive) { | ||
| for (const site of sites) { | ||
| opn(site.url); |
There was a problem hiding this comment.
Use the openInBrowser utility instead of calling opn directly. Additionally, await the call to ensure the browser process is spawned before the CLI process exits. Since openInBrowser returns a promise, awaiting it is best practice here.
| opn(site.url); | |
| await openInBrowser(site.url); |
References
- Look for existing utilities first: Before writing common helper functions (e.g., for logging, file system operations, promises, string manipulation), check
src/utils.tsto see if a suitable function already exists. (link)
1 participant
Description
implement --open for hosting:channel:deploy
Scenarios Tested
Ran the
hosting:channel:deploycommand with--openflagSample Commands