Skip to content

chore: Migrate gsutil usage to gcloud storage #9965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gurusai-voleti wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

chore: Migrate gsutil usage to gcloud storage #9965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39894b1
chore: Migrate gsutil usage to gcloud storage
gurusai-voleti Feb 24, 2026
c9176b7
Merge branch 'main' into ai-gsutil-migration-fc10fb0508784ade878b93f4…
joehan Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .agent/skills/update-pubsub-emulator/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ description: How to update the Pub/Sub emulator
4. **Upload to Storage**
Upload the zip file to the Firebase preview bucket:
```bash
gsutil cp pubsub-emulator-<version>.zip gs://firebase-preview-drop/emulator/
gcloud storage cp pubsub-emulator-<version>.zip gs://firebase-preview-drop/emulator/
```
Make the file publicly readable if necessary (usually the bucket permissions handle this, or use `gsutil acl ch -u AllUsers:R ...`).
Make the file publicly readable if necessary (usually the bucket permissions handle this, or use `gcloud storage objects update ... --add-acl-grant=entity=allUsers,role=READER`).
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The gcloud storage objects update command is used to modify object metadata, including ACLs. The provided command correctly sets the object to be publicly readable. This is a good migration from the gsutil acl ch command.


**Note:** For the version 0.8.27 update, this step was already done.

Expand Down
2 changes: 1 addition & 1 deletion standalone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"fmt": "prettier --write *.js",
"pkg": "pkg -c package.json firepit.js --out-path dist/ && shx chmod +x dist/firepit-*",
"ship": "gsutil -m cp dist/* gs://fir-tools-builds/firepit/ && gsutil iam ch allUsers:objectViewer gs://fir-tools-builds"
"ship": "gcloud storage cp dist/* gs://fir-tools-builds/firepit/ && gcloud storage buckets add-iam-policy-binding gs://fir-tools-builds --member=allUsers --role=objectViewer"
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The migration from gsutil iam ch to gcloud storage buckets add-iam-policy-binding is correct. This ensures that the IAM policy for the bucket is updated to grant objectViewer role to allUsers, maintaining the public readability of the objects. This change adheres to the best practice of using gcloud storage for IAM policy management.

},
"author": "",
"license": "MIT",
Expand Down