Skip to content

Flip resolvers flag.#9967

Draft
rosalyntan wants to merge 1 commit intomainfrom
rosalyntan.cr
Draft

Flip resolvers flag.#9967
rosalyntan wants to merge 1 commit intomainfrom
rosalyntan.cr

Conversation

@rosalyntan
Copy link
Member

Description

Scenarios Tested

Sample Commands

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rosalyntan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily enables the fdcwebhooks feature by default within the Firebase CLI's experimental settings and updates the firebase-functions dependency across several function initialization templates. These changes ensure that new projects or functions leverage the latest firebase-functions version and have the specified webhook feature active out-of-the-box.

Highlights

  • Feature Flag Default: The fdcwebhooks experiment flag has been updated to be enabled by default, changing its value from false to true.
  • Dependency Update: The firebase-functions dependency in various package-ongraphrequest.json templates has been upgraded from version ^7.0.5 to ^7.1.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/experiments.ts
    • Changed the default value of the fdcwebhooks experiment flag from false to true.
  • templates/init/functions/javascript/package-ongraphrequest.lint.json
    • Updated firebase-functions dependency to ^7.1.0.
  • templates/init/functions/javascript/package-ongraphrequest.nolint.json
    • Updated firebase-functions dependency to ^7.1.0.
  • templates/init/functions/typescript/package-ongraphrequest.lint.json
    • Updated firebase-functions dependency to ^7.1.0.
  • templates/init/functions/typescript/package-ongraphrequest.nolint.json
    • Updated firebase-functions dependency to ^7.1.0.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the fdcwebhooks experiment by default and updates the firebase-functions dependency in Data Connect templates. The changes appear correct for enabling this feature.

However, the pull request description is currently empty. The repository's style guide (GEMINI.md, lines 50-56) specifies a structure for commit messages that should be used for pull request descriptions to provide context for the change. Please update the description accordingly.

I've also added a specific comment regarding the missing CHANGELOG.md entry, which is required for user-facing changes.

fdcwebhooks: {
shortDescription: "Enable Firebase Data Connect webhooks feature.",
default: false,
default: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Enabling this experiment by default is a user-facing change. According to the repository style guide, this requires an entry in CHANGELOG.md.

References
  1. For any user-facing change (new features, bug fixes, deprecations), add a corresponding entry to CHANGELOG.md. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant