Modifying configs to use caching configs

[itsrakhil]

Description

Scenarios Tested

Sample Commands

[gemini-code-assist]

Summary of Changes

Hello @itsrakhil, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Data Connect SDK generation by introducing client-side caching configuration capabilities. It allows developers to specify caching behavior directly within their project configurations for various generated SDKs, providing more control over data retrieval and performance.

Highlights

• New CacheSettings Interface: Introduced a new CacheSettings interface to define client-side caching configurations, including maxAge, maxSize, and storage options.
• Client Cache Integration: Added an optional clientCache property, typed as CacheSettings, to all generated SDK interfaces: AdminNodeSDK, JavascriptSDK, SwiftSDK, KotlinSDK, and DartSDK.
• Default Cache Configuration in SDK Generation: Updated the SDK generation logic to automatically include an empty clientCache object when initializing configurations for various SDK types, ensuring the new property is present by default.
• Test Coverage Update: Modified existing test cases to reflect the inclusion of the clientCache property in the generated SDK configurations, ensuring proper validation of the new structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/dataconnect/types.ts
  • Added CacheSettings interface to define caching options.
  • Extended AdminNodeSDK, JavascriptSDK, SwiftSDK, KotlinSDK, and DartSDK interfaces with an optional clientCache property.
  • Removed an outdated comment block.
• src/init/features/dataconnect/sdk.spec.ts
  • Updated test expectations to include clientCache: {} for all generated SDK types (Javascript, Dart, Kotlin, Swift, AdminNode).
• src/init/features/dataconnect/sdk.ts
  • Modified the addSdkGenerateToConnectorYaml function to initialize clientCache: {} for adminNodeSdk, javascriptSdk, dartSdk, kotlinSdk, and swiftSdk configurations.

Activity

• No specific activity (comments, reviews, etc.) was found in the provided context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a clientCache configuration setting for various Data Connect SDKs. The changes are straightforward, adding the new CacheSettings type and applying it to the different SDK configurations. My review includes one suggestion to improve type safety by removing the use of any in the new CacheSettings interface, in accordance with the repository's style guide.

[gemini-code-assist]

The index signature [key: string]: any; allows any property to be added to CacheSettings objects, which weakens type safety. This violates the repository's style guide which advises against using any as an escape hatch. If no other properties are expected on this interface, this line should be removed to enforce stricter type checking.

References

1. The repository style guide at GEMINI.md:38 states: "Never use any or unknown as an escape hatch. Define proper interfaces/types or use type guards." ^(link)