Fixing bad implementation of isFirebaseMCP

src/apiv2.ts

@@ -16,18 +16,19 @@
 
 // Using import would require resolveJsonModule, which seems to break the
 // build/output format.
 const pkg = require("../package.json");
 const CLI_VERSION: string = pkg.version;
 
-const agent = detectAIAgent();
-const agentStr = agent === "unknown" ? "" : ` agent-name/${agent}`;
-const platform = isFirebaseMcp() ? "FirebaseMCP" : "FirebaseCLI";
-const clientVersion = `${platform}/${CLI_VERSION}${agentStr}`;
-
-export const STANDARD_HEADERS: Record<string, string> = {
-  Connection: "keep-alive",
-  "User-Agent": clientVersion,
-  "X-Client-Version": clientVersion,
+export const standardHeaders: () => Record<string, string> = () => {
+  const agent = detectAIAgent();
+  const agentStr = agent === "unknown" ? "" : ` agent-name/${agent}`;
+  const platform = isFirebaseMcp() ? "FirebaseMCP" : "FirebaseCLI";
+  const clientVersion = `${platform}/${CLI_VERSION}${agentStr}`;
+  return {
+    Connection: "keep-alive",
+    "User-Agent": clientVersion,
+    "X-Client-Version": clientVersion,
+  };
 };
 
 // Don't use this one.
@@ -133,7 +134,7 @@
 
 /**
  * Gets a singleton access token
  * @returns An access token
  */
 export async function getAccessToken(): Promise<string> {
   const valid = auth.haveValidTokens(refreshToken, []);
@@ -238,7 +239,7 @@
    * Makes a request as specified by the options.
    * By default, this will:
    *   - use content-type: application/json
    *   - assume the HTTP GET method
    *
    * @example
    * const res = apiv2.request<ResourceType>({
@@ -277,8 +278,8 @@
     }
     try {
       return await this.doRequest<ReqT, ResT>(internalReqOptions);
     } catch (thrown: any) {
       const originalErrorMessage = thrown.original?.message || thrown.message || "";
       if (originalErrorMessage.includes(CLI_OAUTH_PROJECT_NUMBER)) {
         // Error messages mentioning the CLI's OAuth project number should not be shared with end users,
         // since they will never be actionable for them. If we do display them, support gets a bunch of tickets asking for quota
@@ -309,7 +310,7 @@
     if (!reqOptions.headers) {
       reqOptions.headers = new Headers();
     }
-    for (const [h, v] of Object.entries(STANDARD_HEADERS)) {
+    for (const [h, v] of Object.entries(standardHeaders())) {
       if (!reqOptions.headers.has(h)) {
         reqOptions.headers.set(h, v);
       }

src/bin/mcp.ts

@@ -4,6 +4,7 @@ import { resolve } from "path";
 import { parseArgs } from "util";
 import { useFileLogger } from "../logger";
 import { FirebaseMcpServer } from "../mcp/index";
+import { setFirebaseMcp } from "../env";
 import { markdownDocsOfPrompts } from "../mcp/prompts/index.js";
 import { markdownDocsOfResources } from "../mcp/resources/index.js";
 import { markdownDocsOfTools } from "../mcp/tools/index.js";
@@ -82,7 +83,7 @@ export async function mcp(): Promise<void> {
   }
   if (earlyExit) return;
 
-  process.env.IS_FIREBASE_MCP = "true";
+  setFirebaseMcp(true);
   useFileLogger();
   const activeFeatures = (values.only || "")
     .split(",")

src/env.ts

@@ -8,8 +8,13 @@ export function isFirebaseStudio() {
   return googleIdxFolderExists;
 }
 
+let isFirebaseMcpFlag = false;
 export function isFirebaseMcp() {
-  return !!process.env.IS_FIREBASE_MCP;
+  return isFirebaseMcpFlag;
+}
+
+export function setFirebaseMcp(value: boolean) {
+  isFirebaseMcpFlag = value;
 }
 
 // Detect if the CLI was invoked by a coding agent, based on well-known env vars.

src/gcp/cloudsql/fbToolsAuthClient.ts

@@ -39,7 +39,7 @@ export class FBToolsAuthClient extends AuthClient {
   public async getRequestHeaders(): Promise<Record<string, string>> {
     const token = await this.getAccessToken();
     return {
-      ...apiv2.STANDARD_HEADERS,
+      ...apiv2.standardHeaders(),
       Authorization: `Bearer ${token.token}`,
     };
   }