fix functions deployment blocking firebaseextensions.googleapis.com by checking for extensions only when not needed

[Corom]

Description

Today there was an issue (outage) with firebase extension due to some kind of permissions issue resuting in all firebase function deployments failing

extensions: ensuring required API firebaseextensions.googleapis.com is enabled...
Error: Request to https://firebaseextensions.googleapis.com/v1beta/projects/uniqueminds-staging/instances?pageSize=100&pageToken= had HTTP Error: 403, The caller does not have permission

I'm sure a root fix for this will be coming soon, however, for functions that don't use dynamic extensions this check is not needed and there is no reason to block deployments with it. A simple workaround that has unblocked us is to do a proper check for id extensions are needed before checking. this appears to be a bug in the code.

Scenarios Tested

deployed our firebase functions, and we no longer are blocked by the firebaseextensions regression / outage.

Sample Commands

firebase deploy --only functions

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue that was blocking Firebase Functions deployments due to an outage or permission error with the firebaseextensions.googleapis.com API. The change introduces a more robust check to determine if dynamic extensions are truly present and utilized within the codebase before attempting to interact with the extensions API. This ensures that deployments for functions not using extensions are no longer hindered by external service availability or permission problems related to the extensions API.

Highlights

• Firebase Functions Deployment Fix: Modified the condition for checking Firebase Extensions to ensure that the firebaseextensions.googleapis.com API is only called if extensions are actually present and actively used in the codebase, preventing deployment failures due to external API issues when extensions are not relevant.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/deploy/functions/prepare.ts
  • Updated the conditional check for preparing dynamic extensions to explicitly verify if extensions exist and have keys before proceeding.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where function deployments were failing due to an outage in the Firebase Extensions service, even when no extensions were being deployed. The change modifies the condition for preparing dynamic extensions to check not only for the existence of an extensions object in the build, but also to ensure that this object is not empty. This prevents an unnecessary API call to firebaseextensions.googleapis.com when no extensions are part of the deployment, effectively unblocking function deployments that do not use extensions. The fix is correct and directly addresses the problem described.