Fix: Update firebase.json change codebase name#1280
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the codebase name in the Firebase configuration. The reviewer suggests using a more unique codebase name to avoid potential naming collisions when deploying multiple samples, recommending the addition of a source property instead.
| { | ||
| "functions": { | ||
| "codebase": "http-flask" | ||
| "codebase": "functions" |
There was a problem hiding this comment.
Using a generic codebase name like "functions" can lead to naming collisions if a user attempts to deploy multiple samples from this repository to the same Firebase project. It is better to use a unique codebase name, such as "http-flask", and explicitly specify the source directory using the "source" property. This ensures that the Firebase CLI can correctly locate the functions code while maintaining a distinct identity for this sample's functions.
"codebase": "http-flask",
"source": "functions"
No description provided.