ci: always publish all libs on main merges#242
Merged
Conversation
- Replace the long-lived FIREBEND_NPM_KEY token with GitHub Actions OIDC trusted publishing: - Add `permissions: id-token: write` to the release job. - Remove the `.npmrc` auth-token step and `npm whoami`. - Use `actions/setup-node@v4` with `registry-url` configured. - Add `--provenance` to `npm publish` so packages publish with verifiable provenance attestation. - Update `actions/checkout@v2` to `actions/checkout@v4` and pin `ad-m/github-push-action` to `v0.8.0` instead of `master`. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
- Update actions/checkout from v2 to v4. - Add actions/setup-node@v4 with node-version 20 to match the release workflow and ensure consistent Node runtime. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Switch the release script from nx affected to all libraries so that merges to main always publish the web-socket-client library, even when the triggering change was only a workflow or CI file update. Also make the post-publish commit step resilient when there are no changes to commit (e.g., if the build produced no diff). Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
tnschneider
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous release workflow fix landed, but no library was published because the change was only in
.github/files, whichnx affecteddoes not associate with theweb-socket-clientlibrary.This PR changes the release script to publish all libraries on every merge to
maininstead of only affected ones. Since this workspace has a single library (web-socket-client), this is the same effective behavior and avoids silent no-op releases.Also makes the post-publish
git commitstep resilient when there are no changes to commit.Test plan
mainrelease publishesweb-socket-clientto npm.Generated with Devin