Skip to content

fix(agent): remove floci AWS env credentials (FB-2197) - #36

Merged
fstr merged 4 commits into
mainfrom
fstr/remove-floci-aws-env-6149
Jul 15, 2026
Merged

fix(agent): remove floci AWS env credentials (FB-2197)#36
fstr merged 4 commits into
mainfrom
fstr/remove-floci-aws-env-6149

Conversation

@fstr

@fstr fstr commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Background

FB-2197: local floci-backed deploys do not need engine AWS credential environment variables, and the helm-test path should prove the configured object storage can back managed tables.

Summary

  • Remove the AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY entries from the values file generated by scripts/lib/deploy.sh.
  • Remove the same dummy credentials from helm/values-dev.yaml.
  • Update the quickstart, local floci comments, and internal local-development note so the documented local path only configures the floci storage endpoint.
  • Add managed-table SQL coverage to the shared deploy verification and Helm test SQL hook: drop/create/insert/select/drop through the gateway, which exercises the configured floci object-storage path beyond SELECT 1.

Test Plan

  • make lint
  • bash -n scripts/lib/deploy.sh
  • make docs-check

Note

Medium Risk
Touches the default local deploy path and engine object-storage wiring; wrong assumptions about floci auth could break local installs, but changes are narrowly scoped to dev docs/values and additive test coverage.

Overview
Local floci deploys no longer inject dummy AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY on the engine. Those engineSpec.extraEnv blocks are removed from helm/values-dev.yaml, the values snippet built in scripts/lib/deploy.sh, and the quickstart / internal docs; copy now states that floci is zero-auth and only needs customEngineConfig.storage pointed at the floci endpoint.

Deploy and Helm tests now exercise managed-table storage, not just SELECT 1. run_query treats an empty expected substring as success (for DDL/DML with no body). run_managed_table_smoke in deploy.sh runs drop/create/insert/select/drop through the gateway during deploy_and_verify, with a dedicated managed_table phase for agents. The Helm test-sql-query hook uses a shared sql_query helper and the same managed-table sequence per engine.

Reviewed by Cursor Bugbot for commit e453c36. Bugbot is set up for automated code reviews on this repo. Configure here.

@fireboltdb-docs-integration

fireboltdb-docs-integration Bot commented Jul 14, 2026

Copy link
Copy Markdown

Mintlify docs preview

Docs were aggregated into the Firebolt documentation site.

Status Preview Updated (UTC)
🟢 Ready View Preview Jul 14, 2026, 8:21 PM

Mintlify may take a few minutes to finish building. This comment updates on each sync while the source PR is open.

@fstr
fstr marked this pull request as ready for review July 14, 2026 19:35
Comment thread scripts/lib/deploy.sh

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Not approving: Cursor Bugbot reported one unresolved high-severity finding on floci credential removal, and the Bugbot check finished as skipped. Reviewers assigned for human verification.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor
cursor Bot requested review from dig-whois and simonzelenskifbio July 14, 2026 19:44
cursor[bot]
cursor Bot previously approved these changes Jul 14, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4587497. Configure here.

Comment thread scripts/lib/deploy.sh

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Risk: medium. Not approving: Cursor Bugbot reported one unresolved high-severity finding on the latest commit (run_query empty-expected handling), and the Bugbot check finished as skipped. dig-whois and simonzelenskifbio are already assigned as reviewers.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Approved: Cursor Bugbot passed on the latest commit with no unresolved findings, and no Cursor Security Agent check was present. dig-whois and simonzelenskifbio remain assigned as reviewers.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@fstr
fstr merged commit 58b56d3 into main Jul 15, 2026
11 checks passed
@fstr
fstr deleted the fstr/remove-floci-aws-env-6149 branch July 15, 2026 07:04
@fireboltdb-docs-integration

Copy link
Copy Markdown

Packdb docs aggregation ready for review

Docs were merged to main and aggregated into packdb.

Squash-merge the packdb PR into master to publish the docs. Urgent fixes can be cherry-picked to the active release/packdb-* branch like any other docs change.

gm42 added a commit that referenced this pull request Jul 28, 2026
Automated release PR.
---


##
[0.3.0](0.2.0...0.3.0)
(2026-07-27)


### ⚠ BREAKING CHANGES

* **storage:** migrate engine storage config to schema (FB-1684)
([#25](#25))

### Features

* **helm:** add engine authentication and TLS support (FB-1943)
([#23](#23))
([a9a8aa2](a9a8aa2))
* **storage:** migrate engine storage config to schema (FB-1684)
([#25](#25))
([91f1f5d](91f1f5d))


### Bug Fixes

* **agent:** remove floci AWS env credentials (FB-2197)
([#36](#36))
([58b56d3](58b56d3))
* keep the Core UI sidecar image fresh and probe its readiness (FB-2179,
FB-2180)
([#32](#32))
([fb88c96](fb88c96))
* **security:** disable service account token automount on postgres and
gateway
([#47](#47))
([181ac91](181ac91))


### Dependencies

* **deps:** bump packdb appVersion to
release-5.0.1-0.20260709071413.53735f172429
([#5](#5))
([76ecd18](76ecd18))
* **deps:** bump packdb appVersion to
release-5.0.1-0.20260713060957.513515666721
([#29](#29))
([1dd11b3](1dd11b3))
* **deps:** bump packdb appVersion to
release-5.0.1-0.20260727005216.d09b51086f14
([#38](#38))
([69909db](69909db))

---
This PR was generated with Release Please.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Version and changelog metadata plus lint/format guardrails; no chart
template or runtime behavior changes in this diff.
> 
> **Overview**
> **Automated release-please PR** that publishes **`firebolt-instance`
chart `0.3.0`** (from `0.2.0`) and syncs
`.release-please-manifest.json`, `helm/Chart.yaml` `version`, and
`helm/CHANGELOG.md` with the accumulated conventional-commit history
since `0.2.0`.
> 
> The changelog entry highlights **breaking storage config migration**,
**engine auth/TLS**, security and sidecar fixes, and **`appVersion`**
bumps to `release-5.0.1-0.20260727005216.d09b51086f14`. This diff does
not re-land those features—it only records the release.
> 
> **Release CI hygiene:** `helm/Chart.yaml` `sources` moves from flow to
**block** style (with comments), `.yamllint.yaml` relaxes **`brackets`**
spacing so release-please’s `[ "x" ]` formatting does not fail
`validate-chart`, and `helm/AGENTS.md` documents keeping block-style
collections.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
e1e85e3. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: fireboltdb-ci-writer[bot] <207707662+fireboltdb-ci-writer[bot]@users.noreply.github.com>
Co-authored-by: Giuseppe Mazzotta <giuseppe@firebolt.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants