fix(agent): remove floci AWS env credentials (FB-2197) - #36
Conversation
Mintlify docs previewDocs were aggregated into the Firebolt documentation site.
Mintlify may take a few minutes to finish building. This comment updates on each sync while the source PR is open. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4587497. Configure here.
There was a problem hiding this comment.
Stale comment
Risk: medium. Not approving: Cursor Bugbot reported one unresolved high-severity finding on the latest commit (
run_queryempty-expected handling), and the Bugbot check finished as skipped. dig-whois and simonzelenskifbio are already assigned as reviewers.Sent by Cursor Approval Agent: Pull Request Router and Approver
Packdb docs aggregation ready for reviewDocs were merged to Squash-merge the packdb PR into |
Automated release PR. --- ## [0.3.0](0.2.0...0.3.0) (2026-07-27) ### ⚠ BREAKING CHANGES * **storage:** migrate engine storage config to schema (FB-1684) ([#25](#25)) ### Features * **helm:** add engine authentication and TLS support (FB-1943) ([#23](#23)) ([a9a8aa2](a9a8aa2)) * **storage:** migrate engine storage config to schema (FB-1684) ([#25](#25)) ([91f1f5d](91f1f5d)) ### Bug Fixes * **agent:** remove floci AWS env credentials (FB-2197) ([#36](#36)) ([58b56d3](58b56d3)) * keep the Core UI sidecar image fresh and probe its readiness (FB-2179, FB-2180) ([#32](#32)) ([fb88c96](fb88c96)) * **security:** disable service account token automount on postgres and gateway ([#47](#47)) ([181ac91](181ac91)) ### Dependencies * **deps:** bump packdb appVersion to release-5.0.1-0.20260709071413.53735f172429 ([#5](#5)) ([76ecd18](76ecd18)) * **deps:** bump packdb appVersion to release-5.0.1-0.20260713060957.513515666721 ([#29](#29)) ([1dd11b3](1dd11b3)) * **deps:** bump packdb appVersion to release-5.0.1-0.20260727005216.d09b51086f14 ([#38](#38)) ([69909db](69909db)) --- This PR was generated with Release Please. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog metadata plus lint/format guardrails; no chart template or runtime behavior changes in this diff. > > **Overview** > **Automated release-please PR** that publishes **`firebolt-instance` chart `0.3.0`** (from `0.2.0`) and syncs `.release-please-manifest.json`, `helm/Chart.yaml` `version`, and `helm/CHANGELOG.md` with the accumulated conventional-commit history since `0.2.0`. > > The changelog entry highlights **breaking storage config migration**, **engine auth/TLS**, security and sidecar fixes, and **`appVersion`** bumps to `release-5.0.1-0.20260727005216.d09b51086f14`. This diff does not re-land those features—it only records the release. > > **Release CI hygiene:** `helm/Chart.yaml` `sources` moves from flow to **block** style (with comments), `.yamllint.yaml` relaxes **`brackets`** spacing so release-please’s `[ "x" ]` formatting does not fail `validate-chart`, and `helm/AGENTS.md` documents keeping block-style collections. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e1e85e3. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: fireboltdb-ci-writer[bot] <207707662+fireboltdb-ci-writer[bot]@users.noreply.github.com> Co-authored-by: Giuseppe Mazzotta <giuseppe@firebolt.io>



Background
FB-2197: local floci-backed deploys do not need engine AWS credential environment variables, and the helm-test path should prove the configured object storage can back managed tables.
Summary
AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEYentries from the values file generated byscripts/lib/deploy.sh.helm/values-dev.yaml.SELECT 1.Test Plan
make lintbash -n scripts/lib/deploy.shmake docs-checkNote
Medium Risk
Touches the default local deploy path and engine object-storage wiring; wrong assumptions about floci auth could break local installs, but changes are narrowly scoped to dev docs/values and additive test coverage.
Overview
Local floci deploys no longer inject dummy
AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEYon the engine. ThoseengineSpec.extraEnvblocks are removed fromhelm/values-dev.yaml, the values snippet built inscripts/lib/deploy.sh, and the quickstart / internal docs; copy now states that floci is zero-auth and only needscustomEngineConfig.storagepointed at the floci endpoint.Deploy and Helm tests now exercise managed-table storage, not just
SELECT 1.run_querytreats an empty expected substring as success (for DDL/DML with no body).run_managed_table_smokeindeploy.shruns drop/create/insert/select/drop through the gateway duringdeploy_and_verify, with a dedicatedmanaged_tablephase for agents. The Helmtest-sql-queryhook uses a sharedsql_queryhelper and the same managed-table sequence per engine.Reviewed by Cursor Bugbot for commit e453c36. Bugbot is set up for automated code reviews on this repo. Configure here.