#261- Replace manual type checking with PEP 484 type hints#262
Open
Cubix33 wants to merge 1 commit intofireform-core:mainfrom
Open
#261- Replace manual type checking with PEP 484 type hints#262Cubix33 wants to merge 1 commit intofireform-core:mainfrom
Cubix33 wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #261
📝 Description
Removes the outdated and clunky
type_check_all()method in favor of modern Python type hinting. This cleans up the codebase, removes boilerplate validation logic, and allows linters and IDEs to catch type errors automatically.🛠️ Changes Made
type_check_all()method insrc/llm.py.: str,-> dict) to__init__,build_prompt,main_loop,add_response_to_json,handle_plural_values, andget_data.🧪 How to Test
make execordocker compose exec app python3 src/main.py).