Add forms route tests and register AppError handler#267
Open
Mingqwqqaq wants to merge 1 commit intofireform-core:mainfrom
Open
Add forms route tests and register AppError handler#267Mingqwqqaq wants to merge 1 commit intofireform-core:mainfrom
Mingqwqqaq wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves route-level reliability around form submission. Closes #265
Changes
AppErrorhandler inapi/main.py/forms/fill/forms/fill/forms/fillreturning404/templates/createassertionsWhy
The forms route already raises
AppErrorfor missing templates, but the app was not registering the exception handler, so the intended API behavior was incomplete.The existing
tests/test_forms.pyfile was also still a stub, so the main submission path had no meaningful coverage.Testing
Added API tests using
monkeypatchto isolate route behavior from: