fix: register custom exception handlers in FastAPI app#296
Open
SouravVerma-art wants to merge 2 commits intofireform-core:mainfrom
Open
fix: register custom exception handlers in FastAPI app#296SouravVerma-art wants to merge 2 commits intofireform-core:mainfrom
SouravVerma-art wants to merge 2 commits intofireform-core:mainfrom
Conversation
|
Nice fix — I noticed similar behavior while testing locally where some errors were returning 500 instead of the expected status codes. Registering the exception handlers makes sense and aligns the API responses with the intended design. I’ll test this locally to verify different error scenarios. |
Author
|
Thanks for the feedback! Yes, the issue was that the custom exception handlers were never registered, so FastAPI was falling back to the default 500 responses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom exception handlers were defined but never registered with the FastAPI app, causing
AppErrorto fall back to FastAPI's default handler and return500 Internal Server Errorinstead of the intended status code.Changes
register_exception_handlersinmain.pyregister_exception_handlers(app)before router registrationWhy
Without this fix:
AppError(status_code=404)incorrectly returns500Related
Closes #295