Add configurable schema enforcement and structured JSON validation for extraction pipeline#303
Open
ayushhbasu wants to merge 11 commits intofireform-core:mainfrom
Open
Add configurable schema enforcement and structured JSON validation for extraction pipeline#303ayushhbasu wants to merge 11 commits intofireform-core:mainfrom
ayushhbasu wants to merge 11 commits intofireform-core:mainfrom
Conversation
Adds a function to validate required fields in extracted data.
Integrate validation into controller flow
Add unit tests for validation utility
Add a test for form validation failure in Controller. dd validation + tests
Refactor validation to use REQUIRED_FIELDS from schema.
Add a test for form validation failure in Controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the basic validation layer by introducing schema-based enforcement,
making the pipeline more extensible for different agency requirements.
Description
This PR extends the existing validation layer by introducing schema-based enforcement for extracted data within the pipeline.
A centralized schema (
REQUIRED_FIELDS) has been added insrc/schema.pyto define required fields along with their expected data types. The validation logic has been refactored to dynamically validate incoming structured data against this schema, ensuring both field presence and type correctness.This change improves the flexibility and scalability of the system by enabling future support for agency-specific schemas without modifying core validation logic.
Additionally, test cases have been updated to align with the new schema and expanded to cover type validation scenarios, improving overall test coverage and robustness.
Fixes # (issue)
Type of change
How Has This Been Tested?
The updated validation logic has been tested using unit tests covering the following scenarios:
Steps to reproduce:
Test Configuration:
Checklist: