Skip to content

Improve preview link discovery#6149

Merged
mstange merged 2 commits into
firefox-devtools:mainfrom
skylarkning:improve-preview-link-discovery
Jul 7, 2026
Merged

Improve preview link discovery#6149
mstange merged 2 commits into
firefox-devtools:mainfrom
skylarkning:improve-preview-link-discovery

Conversation

@skylarkning

@skylarkning skylarkning commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The preview-link bot now will follow referenced PRs as well as issues.
  • Let it reuse paths from existing Main and Deploy preview links.
  • Keep broken share.firefox.dev links non-fatal so the bot can keep looking or fall back to /.

Example

If PR #6137 says Follow-up to #6017, and #6017 has:

[Main](https://main--perf-html.netlify.app/public/abc/)

then the bot can add this to PR #6137:

[Main](https://main--perf-html.netlify.app/public/abc/) | [Deploy preview](https://deploy-preview-6137--perf-html.netlify.app/public/abc/)

Test

node --test .github/scripts/add-preview-links.test.mjs

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.50%. Comparing base (b894055) to head (b2c0eba).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6149   +/-   ##
=======================================
  Coverage   83.50%   83.50%           
=======================================
  Files         342      342           
  Lines       36522    36522           
  Branches    10221    10224    +3     
=======================================
  Hits        30497    30497           
  Misses       5597     5597           
  Partials      428      428           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread .github/scripts/add-preview-links.mjs Outdated
@skylarkning skylarkning force-pushed the improve-preview-link-discovery branch 3 times, most recently from f6b4480 to dff6be2 Compare July 7, 2026 15:07
@skylarkning skylarkning force-pushed the improve-preview-link-discovery branch from dff6be2 to 0f717c1 Compare July 7, 2026 15:33
@skylarkning skylarkning requested a review from mstange July 7, 2026 17:34
@mstange mstange enabled auto-merge July 7, 2026 18:18
@mstange mstange merged commit faf67a7 into firefox-devtools:main Jul 7, 2026
21 checks passed
@canova canova mentioned this pull request Jul 9, 2026
canova added a commit that referenced this pull request Jul 9, 2026
Changes:

[Nazım Can Altınova] Bump profiler-cli version to 0.4.0 (#6132)
[Florian Quèze] Add "/" and "f" keyboard shortcuts to focus the panel
filter box (#6025)
[Markus Stange] Change profile.shared.stackTable.prefix to prefixOffset
(delta from current index) (#6089)
[Sky Ning] Add workflow to insert PR preview links (#6133)
[Markus Stange] Implement column sorting in the marker table (#6083)
[Markus Stange] Make it easier to create upside-down flame graphs
(#6128)
[Markus Stange] Use appropriate highlighter dialects for ts + jsx
(#6141)
[cathaysia] style: add .editorconfig (#6142)
[Nazım Can Altınova] Prevent long source URLs from overflowing the code
error overlay (#6147)
[Nazım Can Altınova] Extract a runCommand helper for profiler-cli
command handlers (#6148)
[Markus Stange] feat(theme): add color-scheme meta (#6150)
[Nazım Can Altınova] Add an early throw for the this.querier and remove
the non-null asserts in the cli codebase (#6145)
[Markus Stange] feat: invert call stack in flame graph to render as
icicle graph (#6090)
[Markus Stange] Improve preview link discovery (#6149)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (July 9, 2026) (#6155)

And special thanks to our localizers:

de: Michael Köhler
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Fjoerfoks
ru: Valery Ledovskoy
tr: Nazım Can Altınova
zh-TW: Pin-guang Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants