Only render a marker url field as a link when the whole value is a URL#6163
Open
canova wants to merge 1 commit into
Open
Only render a marker url field as a link when the whole value is a URL#6163canova wants to merge 1 commit into
canova wants to merge 1 commit into
Conversation
Before this commit, renderMarkerFieldValue linkified any url-format field whose value started with `http(s)://`, using the entire value as the href. But it might be possible to have a string that starts with a URL and then continues with a regular text. This commit covers this case as well so it doesn't incorrectly turns invalid urls into clickable links. Now we require the value to be entirely a URL before rendering a link. otherwise fall back to plain text.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6163 +/- ##
=======================================
Coverage 83.50% 83.50%
=======================================
Files 342 342
Lines 36522 36523 +1
Branches 10224 10125 -99
=======================================
+ Hits 30497 30499 +2
+ Misses 5597 5596 -1
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mstange
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Before this commit, renderMarkerFieldValue linkified any url-format field whose value started with
http(s)://, using the entire value as the href. But it might be possible to have a string that starts with a URL and then continues with a regular text. This commit covers this case as well so it doesn't incorrectly turns invalid urls into clickable links.Now we require the value to be entirely a URL before rendering a link. otherwise fall back to plain text.