Show each counter's owning process in profiler-cli#6164
Open
fatadel wants to merge 1 commit into
Open
Conversation
Counters listed by "pq counter list" gave no hint about which process they belonged to, so profiles with many identically-named counters (one "Process CPU" per process) were impossible to tell apart. Each counter line now carries its process handle, name, and pid, mirroring how "profile info" labels processes so the two outputs cross-reference: c-2: Process CPU (CPU) [p-0 Parent Process, pid 47021] [2787 samples] "counter info" gains a matching Process line. The handle is dropped when the owning process can't be resolved, leaving just the name and pid. Closes firefox-devtools#6134
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6164 +/- ##
==========================================
+ Coverage 83.50% 83.52% +0.02%
==========================================
Files 342 342
Lines 36522 36623 +101
Branches 10125 10163 +38
==========================================
+ Hits 30497 30590 +93
- Misses 5597 5606 +9
+ Partials 428 427 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Counters listed by "pq counter list" gave no hint about which process they belonged to, so profiles with many identically-named counters (one "Process CPU" per process) were impossible to tell apart. Each counter line now carries its process handle, name, and pid, mirroring how "profile info" labels processes so the two outputs cross-reference:
c-2: Process CPU (CPU) [p-0 Parent Process, pid 47021] [2787 samples]
"counter info" gains a matching Process line. The handle is dropped when the owning process can't be resolved, leaving just the name and pid.
Closes #6134
Example profile
Main changes:
pq counter listshows concise identifying information for the related process of each counter:pq counter info <handle>adds the same information under "Process:" line: