disable sending 'all white space' messages#4
Open
chmus wants to merge 1 commit intofireship-io:masterfrom
chmus:patch-1
Open
disable sending 'all white space' messages#4chmus wants to merge 1 commit intofireship-io:masterfrom chmus:patch-1
chmus wants to merge 1 commit intofireship-io:masterfrom
chmus:patch-1
Conversation
Chat currently does not check whether the message is 'all white space' text. This small addition should fix it. However, I am currently unable to test if this will work, so it can be a wrong fix.
|
Looks fine, but would be shorter and possibly faster if you used String.prototype.trim() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chat currently does not check whether the message is 'all white space' text. This small addition should fix it.
However, I am currently unable to test if this will work, so it can be a wrong fix.
P. S. By the way, I am experienced neither in making pull requests nor in React 😅. Hopefully, it will not cause any problems.