Support beautification of HTTP 100 responses.#8
Open
jparise wants to merge 2 commits intofireteam:masterfrom
Open
Support beautification of HTTP 100 responses.#8jparise wants to merge 2 commits intofireteam:masterfrom
jparise wants to merge 2 commits intofireteam:masterfrom
Conversation
Detect when the server sends an HTTP 100 (Continue) response header
and kick our beautification loop into 'continuing' mode. While in
this mode, we wait for another ^HTTP/ header to be received before
responding to the `\r\n` break sequence signalling the end of the
headers and the start of the body. This gives us output like:
HTTP/1.1 100 (Continue)
HTTP/1.1 200 OK
Content-Length: 387
Content-Type: application/json; charset=UTF-8
{
}
This comes into play when uploading files using curlish.
Previously, these types of HTTP conversations were not "beautified"
because the header processing loop bailed out after the initial
`HTTP/1.1 100 (Continue)\r\n\r\n` content was handled.
Contributor
|
I will apply this. I wonder though it it makes sense to match for |
Author
|
That's probably a good improvement. The same would apply to the existing |
Author
|
@mitsuhiko, would you consider merging this for a future release? |
Contributor
|
Yes, will do that. Just have to check that it works :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect when the server sends an
HTTP 100 (Continue)response headerand kick our beautification loop into 'continuing' mode. While in
this mode, we wait for another
^HTTP/header to be received beforeresponding to the
\r\nbreak sequence signalling the end of theheaders and the start of the body. This gives us output like:
This comes into play when uploading files using curlish.
Previously, these types of HTTP conversations were not "beautified"
because the header processing loop bailed out after the initial
HTTP/1.1 100 (Continue)\r\n\r\ncontent was handled.