v3.3.2 - fix RPi-Pico Analogue port number#183
Closed
PizzaProgram wants to merge 1 commit intofirmata:masterfrom
Closed
v3.3.2 - fix RPi-Pico Analogue port number#183PizzaProgram wants to merge 1 commit intofirmata:masterfrom
PizzaProgram wants to merge 1 commit intofirmata:masterfrom
Conversation
Contributor
Author
|
More info here ... |
Contributor
Author
|
@pgrawehr Can you please merge this change too? ... and create a new RELEASE from the current state of code? |
Contributor
|
I'll look after it, but I'm rather busy at the moment, so might take a few days still. |
Contributor
Author
|
WAIT. No need to accept this yet. Changing: TOTAL_ANALOG_PINS 5is not enough. Also: #define TOTAL_PINS 31must be increased. Yet, these changes are still not enough to read the temperature value :-(This code works fine at #include <stdio.h>
float f = analogReadTemp();
char buf[50], buf2[10];
snprintf(buf, 16, "{\"temp\": %f, ", f);
strcat(buf, ", \"totalApins\": ");
snprintf(buf2, 10, "%i }", TOTAL_ANALOG_PINS );
strcat(buf, buf2);
Firmata.sendString(F( buf )); |
Contributor
Author
|
Now Confirmed: Need to change TOTAL for Pico board, from 30 -> to 31 too ! #define TOTAL_ANALOG_PINS 5
#define TOTAL_PINS 31See here ... |
Contributor
Author
|
If we are about to change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info here...