Open
Conversation
dawnerd
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see an increasing number of errors that we can't seem to get rid of. They seem to be triggered by extensions or other parties. They usually are stack-less errors or filename-less ones.
With that in mind, I've refactored the filter function to be able to be more extensive and be reused.
However, I've realized that 404 AJAX errors have no stack and also, no file.
Unsure of what's the best way to handle these errors with this in mind. I wouldn't like to complicate logic much much further on this since this should likely be simple.
@orthagonal and @jgallen23 any ideas?