FCE-2844: Fix docs bare workflow tab prebuild#233
Open
MiloszFilimowski wants to merge 2 commits intomainfrom
Open
FCE-2844: Fix docs bare workflow tab prebuild#233MiloszFilimowski wants to merge 2 commits intomainfrom
MiloszFilimowski wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes the React Native Quick Start tutorial documentation by properly differentiating build instructions between Expo and bare workflow users. Previously, the npx expo prebuild command was shown unconditionally to all users, which was incorrect for bare workflow setups.
Changes:
- Wrapped the "Build native dependencies" step in Expo/Bare workflow tabs
- Expo users now see
npx expo prebuild, bare workflow users seecd ios && pod install - Changes applied consistently to both current docs (
docs/) and versioned docs (versioned_docs/version-0.25.0/)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/tutorials/react-native-quick-start.mdx | Added Expo/Bare workflow tabs around build native dependencies instructions |
| versioned_docs/version-0.25.0/tutorials/react-native-quick-start.mdx | Applied identical tab structure to versioned documentation for consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
npx expo prebuild, bare workflow users seecd ios && pod installdocs/(next) andversioned_docs/version-0.25.0/Motivation and Context
The
npx expo prebuildcommand was shown unconditionally to all users, including bare workflow users who don't use Expo. This was confusing and incorrect for non-Expo setups.