Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents the mobile SDK's built-in permission management hooks and updates installation guidance to reference them instead of third-party libraries.
Changes:
- Added "Managing Permissions (Mobile only)" section to
managing-devices.mdxdocumentinguseCameraPermissionsanduseMicrophonePermissionshooks - Updated
installation.mdxto link to the new Managing Permissions section instead of recommending third-party libraries - Bumped
web-client-sdksubmodule
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/web-client-sdk | Updated submodule commit reference |
| docs/how-to/client/managing-devices.mdx | Added comprehensive documentation for permission hooks with usage example |
| docs/how-to/client/installation.mdx | Replaced third-party library recommendations with link to new Managing Permissions section |
Comments suppressed due to low confidence (1)
docs/how-to/client/managing-devices.mdx:278
- The
RoomScreencomponent doesn't return any JSX. Add a return statement with component markup or clarify in a comment that this is a simplified example showing only the permission logic.
function RoomScreen() {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MiloszFilimowski
force-pushed
the
mfilimowski/FCE-2869-permission-helpers
branch
from
c2168a2 to
ded0591
Compare
MiloszFilimowski
force-pushed
the
mfilimowski/FCE-2869-permission-helpers
branch
from
ded0591 to
16f9cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useCameraPermissionsanduseMicrophonePermissionshooks with query/request API and usage exampleexpo-permissions/react-native-permissionsrecommendation with a link to the new Managing Permissions sectionweb-client-sdksubmoduleMotivation and Context
The mobile SDK now ships built-in permission hooks (
useCameraPermissions,useMicrophonePermissions), so the docs should guide users to those instead of third-party libraries.