Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new server notification types to represent “track forwarding” lifecycle events and updates the Elixir protobuf toolchain/docs accordingly.
Changes:
- Bump
protobufElixir dependency from0.15.xto0.16.xand refresh lockfile. - Extend
ServerMessagewithTrackForwarding/TrackForwardingRemovedmessages (proto + generated.pb.ex). - Regenerate/update markdown docs and README instructions to reflect the new protobuf tooling/version.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| fishjam_protos/mix.lock | Locks protobuf to 0.16.0. |
| fishjam_protos/mix.exs | Bumps protobuf dependency requirement to ~> 0.16.0. |
| fishjam_protos/lib/fishjam/server_notifications.pb.ex | Regenerated Elixir modules for new notifications + updated field metadata/deprecations. |
| fishjam/server_notifications.proto | Adds new TrackForwarding* messages and reorganizes oneof (also introduces new deprecations). |
| doc/docs.md | Adds documentation sections for the new messages and updates the ServerMessage oneof table. |
| README.md | Updates protobuf plugin install command to 0.16.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AHGIJMKLKKZNPJKQR
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes.
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact