Skip to content

Track forwarding notifications#45

Merged
roznawsk merged 2 commits intomasterfrom
FCE-2859-track-forwarding-notifications
Feb 27, 2026
Merged

Track forwarding notifications#45
roznawsk merged 2 commits intomasterfrom
FCE-2859-track-forwarding-notifications

Conversation

@roznawsk
Copy link
Member

Description

Describe your changes.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

@roznawsk roznawsk requested a review from Copilot February 25, 2026 15:30
@linear
Copy link

linear bot commented Feb 25, 2026

@roznawsk roznawsk marked this pull request as ready for review February 25, 2026 15:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new server notification types to represent “track forwarding” lifecycle events and updates the Elixir protobuf toolchain/docs accordingly.

Changes:

  • Bump protobuf Elixir dependency from 0.15.x to 0.16.x and refresh lockfile.
  • Extend ServerMessage with TrackForwarding / TrackForwardingRemoved messages (proto + generated .pb.ex).
  • Regenerate/update markdown docs and README instructions to reflect the new protobuf tooling/version.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
fishjam_protos/mix.lock Locks protobuf to 0.16.0.
fishjam_protos/mix.exs Bumps protobuf dependency requirement to ~> 0.16.0.
fishjam_protos/lib/fishjam/server_notifications.pb.ex Regenerated Elixir modules for new notifications + updated field metadata/deprecations.
fishjam/server_notifications.proto Adds new TrackForwarding* messages and reorganizes oneof (also introduces new deprecations).
doc/docs.md Adds documentation sections for the new messages and updates the ServerMessage oneof table.
README.md Updates protobuf plugin install command to 0.16.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roznawsk roznawsk merged commit efc8959 into master Feb 27, 2026
4 checks passed
@roznawsk roznawsk deleted the FCE-2859-track-forwarding-notifications branch February 27, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants