FCE-2848; FCE-2849: Fix missing yarn build step in examples#483
Merged
MiloszFilimowski merged 2 commits intomainfrom Feb 26, 2026
Merged
FCE-2848; FCE-2849: Fix missing yarn build step in examples#483MiloszFilimowski merged 2 commits intomainfrom
MiloszFilimowski merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates mobile client example READMEs to ensure consistent and complete setup instructions. The primary issue addressed is that the minimal-react-native example was missing critical yarn build and npx expo prebuild steps that would cause setup failures for new users. Additionally, the PR standardizes formatting, corrects license references, and improves consistency across all mobile client examples.
Changes:
- Added missing
yarn buildandnpx expo prebuild --cleansteps tominimal-react-nativeexample - Consolidated installation steps and added
yarn buildtotext-chatexample - Corrected license references from MIT to Apache License 2.0 and fixed LICENSE file paths from
../../LICENSEto../../../LICENSE - Standardized code block language from
cmdtoshinfishjam-chatfor consistency - Updated
.env.exampleformatting to remove placeholder values
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/mobile-client/video-player/README.md | Added --clean flag to npx expo prebuild command for consistency |
| examples/mobile-client/video-player/.env.example | Removed placeholder value to match format of other examples |
| examples/mobile-client/text-chat/README.md | Consolidated installation steps, added yarn build step, corrected license reference and path, removed redundant "yarn start" section |
| examples/mobile-client/minimal-react-native/README.md | Added critical missing yarn build and npx expo prebuild --clean steps, corrected license reference and path, improved environment setup instructions |
| examples/mobile-client/fishjam-chat/README.md | Changed code block language from cmd to sh for consistency with other examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Mobile client example READMEs had inconsistent and incomplete setup instructions — most notably
minimal-react-nativewas missing the requiredyarn buildandnpx expo prebuildsteps, which would cause the example to fail for new users.Documentation impact
Types of changes
not work as expected)