Skip to content

FCE-2848; FCE-2849: Fix missing yarn build step in examples#483

Merged
MiloszFilimowski merged 2 commits intomainfrom
mfilimowski/fce-2848-fix-examples
Feb 26, 2026
Merged

FCE-2848; FCE-2849: Fix missing yarn build step in examples#483
MiloszFilimowski merged 2 commits intomainfrom
mfilimowski/fce-2848-fix-examples

Conversation

@MiloszFilimowski
Copy link
Collaborator

@MiloszFilimowski MiloszFilimowski commented Feb 26, 2026

Description

  • Updated the examples README to be up to date.

Motivation and Context

Mobile client example READMEs had inconsistent and incomplete setup instructions — most notably minimal-react-native was missing the required yarn build and npx expo prebuild steps, which would cause the example to fail for new users.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear
Copy link

linear bot commented Feb 26, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates mobile client example READMEs to ensure consistent and complete setup instructions. The primary issue addressed is that the minimal-react-native example was missing critical yarn build and npx expo prebuild steps that would cause setup failures for new users. Additionally, the PR standardizes formatting, corrects license references, and improves consistency across all mobile client examples.

Changes:

  • Added missing yarn build and npx expo prebuild --clean steps to minimal-react-native example
  • Consolidated installation steps and added yarn build to text-chat example
  • Corrected license references from MIT to Apache License 2.0 and fixed LICENSE file paths from ../../LICENSE to ../../../LICENSE
  • Standardized code block language from cmd to sh in fishjam-chat for consistency
  • Updated .env.example formatting to remove placeholder values

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/mobile-client/video-player/README.md Added --clean flag to npx expo prebuild command for consistency
examples/mobile-client/video-player/.env.example Removed placeholder value to match format of other examples
examples/mobile-client/text-chat/README.md Consolidated installation steps, added yarn build step, corrected license reference and path, removed redundant "yarn start" section
examples/mobile-client/minimal-react-native/README.md Added critical missing yarn build and npx expo prebuild --clean steps, corrected license reference and path, improved environment setup instructions
examples/mobile-client/fishjam-chat/README.md Changed code block language from cmd to sh for consistency with other examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MiloszFilimowski MiloszFilimowski changed the title FCE-2848: Fix missing yarn build step in examples FCE-2848; FCE-2849: Fix missing yarn build step in examples Feb 26, 2026
@MiloszFilimowski MiloszFilimowski merged commit 258f457 into main Feb 26, 2026
2 checks passed
@MiloszFilimowski MiloszFilimowski deleted the mfilimowski/fce-2848-fix-examples branch February 26, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants