Conversation
src/types.ts
Outdated
| } | ||
|
|
||
| export type Apps = { | ||
| [property: string]: string |
There was a problem hiding this comment.
🤔 Since this is mainly app names, have you considered something like AppName[]? We will likely have an App type in the future, so this may conflict with what one would expect from a plural of those.
There was a problem hiding this comment.
That said, I’ll leave it to @icidasset and @dholms to weigh in here; they’re deeper in the TS client than I am (it’s been a while)
There was a problem hiding this comment.
I would do something along the lines of:
type App = { domain: string }
type Apps = Array<App> // sorted by domainThere was a problem hiding this comment.
And maybe remove the Apps type entirely, and just use Array<App> instead.
There was a problem hiding this comment.
Thanks guys for the review! I made the type changes, hopefully thats more along of the lines of what you wanted
3 participants
Summary
This PR fixes/implements the following features
Added the following API requests to the sdk
Added two relevant tests & documentation.