Conversation
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-reneeli this generally looks good with just a few small reminder and suggestion comments. This will be ready once the upstream PRs are approved
CHANGELOG.md
Outdated
| # dbt_app_reporting v0.5.0 | ||
|
|
||
| ## Breaking Changes | ||
| - This package has been upgraded following schema changes upstream in the `dbt_apple_store` package. For more information, refer to the `dbt_apple_store` [release notes](https://github.com/fivetran/dbt_apple_store/releases/tag/v0.5.0). |
There was a problem hiding this comment.
Can you highlight here if any changes other than the upstream dependency switch are expected for the customer here?
There was a problem hiding this comment.
I don't think there any changes specific to this package. Though I did update the language to highlight that there are breaking changes in the upstream packages referenced.
packages.yml
Outdated
| - git: https://github.com/fivetran/dbt_apple_store.git | ||
| revision: nov_2024_schema | ||
| warn-unpinned: false | ||
|
|
||
| # - package: fivetran/apple_store | ||
| # version: [">=0.5.0", "<0.6.0"] | ||
|
|
There was a problem hiding this comment.
Reminder to switch before merge and release
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-reneeli Can you update the README with the new versions of dbt_app_reporting and dbt_apple_store?
Thanks @fivetran-avinash for catching! Updated this along with mentioning the new version of apple store in the CHANGELOG |
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-reneeli LGTM!
3 participants
PR Overview
This PR will address the following Issue/Feature: #28
This PR will result in the following new package version: v0.5.0
Schema changes from Nov 2024
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
to be completed
Breaking Changes
dbt_apple_storepackage. For more information, refer to thedbt_apple_storerelease notes.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃