Conversation
| cast(platform_version as {{ dbt.type_string() }}) as platform_version, | ||
| cast(source_type as {{ dbt.type_string() }}) as source_type, | ||
| cast(page_type as {{ dbt.type_string() }}) as page_type, | ||
| cast(pre_order as {{ dbt.type_string() }}) as pre_order, |
There was a problem hiding this comment.
just fyi. would have thought this is a boolean but apple docs has it as a string.
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
@fivetran-reneeli thanks for this PR. A few comments below following this review.
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
A few small changes. Once these are addressed this will be ready for release review for pre-release
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
fivetran-joemarkiewicz
left a comment
fivetran-joemarkiewicz
left a comment
There was a problem hiding this comment.
A few final change requests before approval
README.md
Outdated
| packages: | ||
| - package: fivetran/apple_store_source | ||
| version: [">=0.4.0", "<0.5.0"] # we recommend using ranges to capture non-breaking changes automatically | ||
| version: 0.5.0-a1 |
There was a problem hiding this comment.
Reminder to now update this to be the new range.
models/src_apple_store.yml
Outdated
| sources: | ||
| - name: apple_store # This source will only be used if you are using a single apple_store source connector. If multiple sources are being unioned, their tables will be directly referenced via adapter.get_relation. | ||
| schema: "{{ var('apple_store_schema', 'itunes_connect') }}" | ||
| schema: "{{ var('apple_store_schema', 'apple_appstore') }}" |
There was a problem hiding this comment.
Is this accurate? This is actually a very important piece for Quickstart to work. The default schema must be what the default schema provided by the connector. In this case it looks like it's still itunes_connect.
We need to keep that default schema.
There was a problem hiding this comment.
Gotcha-- reverted!
README.md
Outdated
| version: 0.5.0-a1 | ||
| ``` | ||
| ### Step 3: Define database and schema variables | ||
| By default, this package runs using your destination and the `apple_store` schema. If this is not where your apple_store data is (for example, if your apple_store schema is named `apple_store_fivetran`), add the following configuration to your root `dbt_project.yml` file: |
There was a problem hiding this comment.
Let's also update this based on the previous comment to state the following
| By default, this package runs using your destination and the `apple_store` schema. If this is not where your apple_store data is (for example, if your apple_store schema is named `apple_store_fivetran`), add the following configuration to your root `dbt_project.yml` file: | |
| By default, this package runs using your destination and your Apple Store schema (default `itunes_connect`). If this is not where your Apple Store data is (for example, if your Apple Store schema is named `apple_store_fivetran`), add the following configuration to your root `dbt_project.yml` file: |
| - Following the connector's [Nov 2024 Update](https://fivetran.com/docs/connectors/applications/apple-app-store/changelog#november2024) to sync from the [App Store Connect API](https://developer.apple.com/documentation/appstoreconnectapi), we've updated this dbt package to reflect the new schema which includes the following changes: | ||
|
|
||
| - *Models Removed*: | ||
| - `stg_apple_store__app_store_device` |
There was a problem hiding this comment.
I think stg_apple_store__crashes_platform_version got removed too?
There was a problem hiding this comment.
added to changelog!
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-reneeli I think there is one changelog update you need to make.
|
Hi team — we're updating to 0.5.0 right now, and we can't find the We were hoping to get access to all the tables that are in Fivetran ERD. Thanks! |
|
Hi @pestrov! We only bring in the raw tables that we used downstream in the transformed models (which are in this downstream package here). We don't use We also welcome you to create a feature request here. |
4 participants
PR Overview
This PR will address the following Issue/Feature: #28
This PR will result in the following new package version: v0.5.0-a1
Schema changes from Nov 2024
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
to be completed
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
If you had to summarize this PR in an emoji, which would it be?
💃