Draft
Conversation
fivetran-joemarkiewicz
added
the
docs:ready
Contributor
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
A thought and a suggestion. Approved for pre-release.
| from {{ var('log') }} No newline at end of file | ||
| from {{ var('log') }} | ||
| {% if var('fivetran_platform_lookback_window_months', none) is not none %} | ||
| where time_stamp >= cast({{ dbt.dateadd('month', -var('fivetran_platform_lookback_window_months', none), dbt.current_timestamp()) }} as {{ dbt.type_timestamp() }}) |
Contributor
There was a problem hiding this comment.
I think this cast is redundant? dbt.dateadd is timestamp compatible.
Contributor
Author
There was a problem hiding this comment.
Since time_stamp is a timestamp datatype and dbt.dateadd returns a datetime datatype I need to cast as timestamp in order to ensure the where clause succeeds.
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com> Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-joemarkiewicz
added
the
pre-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog