Open
Conversation
fivetran-jamie
commented
Apr 2, 2026
| @@ -0,0 +1,44 @@ | |||
| {% macro fivetran_log_json_parse_dev(string, string_path) -%} | |||
Contributor
Author
There was a problem hiding this comment.
For testing -- I didn't want to edit the current fivetran_log_json_parse macro directly because this required updates to the other models, and this is a very experimental pre-release that I don't wanna sink too much into
fivetran-jamie
commented
Apr 2, 2026
fivetran-jamie
commented
Apr 2, 2026
|
|
||
| {% endmacro %} | ||
|
|
||
| {% macro redshift__convert_to_json(string) %} |
Contributor
Author
There was a problem hiding this comment.
Necessary because Redshift will otherwise inherit Postgres' macro
fivetran-jamie
added
docs:ready
Contributor
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-jamie Few comments before approval.
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
Contributor
fivetran-avinash
left a comment
fivetran-avinash
left a comment
There was a problem hiding this comment.
@fivetran-jamie one other suggestion but it's minor, approved for pre-release.
Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com>
fivetran-jamie
added
docs:ready
fivetran-jamie
added
docs:ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
Submission Checklist
Changelog