Skip to content

Update/v3.2.x-workaround -u3v jump frame#359

Merged
Fixstars-momoko merged 7 commits into
mainfrom
update/v3-u3v-jump-frame
Feb 26, 2026
Merged

Update/v3.2.x-workaround -u3v jump frame#359
Fixstars-momoko merged 7 commits into
mainfrom
update/v3-u3v-jump-frame

Conversation

@xinyuli1204
Copy link
Copy Markdown
Contributor

@xinyuli1204 xinyuli1204 commented Feb 24, 2026

  • introduce the workaround from client for v3.x
  • upgrade cdci windows-2019 to windows-2022 since github cdci windows-2019 is deprecated

@xinyuli1204 xinyuli1204 self-assigned this Feb 24, 2026
Comment thread src/bb/image-io/rt_u3v.h Outdated

#define TIMEOUT_IN_US_SHORTER 3 * 1000 * 1000
#define TIMEOUT_IN_US_LONGER 30 * 1000 * 1000
#define Frame_Jump_Threshold 1000
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use UPPER_SNAKE_CASE for Macro

Comment thread src/bb/image-io/rt_u3v.h Outdated
Comment thread src/bb/image-io/rt_u3v.h Outdated
#endif
}

static inline void log_det_illegal_frame_event(const char *tag, uint32_t before, uint32_t after, uint32_t frame_cnt_, int64_t adiff) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use log::debug

Comment thread src/bb/image-io/rt_u3v.h Outdated
@xinyuli1204
Copy link
Copy Markdown
Contributor Author

@Fixstars-momoko could you review it again?
sorry debug level is still below the trace, if enable trace, the debug would be printed

@Fixstars-momoko Fixstars-momoko self-requested a review February 25, 2026 18:33
Comment thread src/bb/image-io/rt_u3v.h Outdated
protected:

// ---- illeagal frame test logging (enable/disable) ----
#ifndef U3V_IFT_LOG_ENABLE
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this macro and can show the log with debug and trace.

Copy link
Copy Markdown
Contributor

@Fixstars-momoko Fixstars-momoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fixstars-momoko Fixstars-momoko merged commit b68c43b into main Feb 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants