fix(main): report transition-assertion failures on the inbound link#362
Merged
Merged
Conversation
CheckTransitionInvariants stores its failure metadata on the *inbound link* (node.Inbound[0].FailedInvariants) rather than on the node's Process.FailedInvariants — see processor.go where the write happens. The failure-reporting branch in modelCheckSingleSpec only looked at the Process field, with these wrong consequences: - Simulation mode: a transition-assertion failure fell through to "FAILED: Model checker failed. Deadlock/stuttering detected", which is misleading (deadlock_detection: false in the spec confirms it was not a deadlock). - Model-checking mode: nothing about the failure was printed at all, only the raw trace dump from dumpFailedNode. Now: if the node has no Process.FailedInvariants, check the inbound link. Print "Transition Invariant: <name>" if found. Add a generic "Model checker failed (no failed-invariant metadata...)" fallback for model-checking mode so silence never happens. Reproducer: a spec with a `transition assertion` that the model checker finds violating — previously misreported. Confirmed both modes now print the assertion name (TerminalStatesRemainTerminal in the test spec). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CheckTransitionInvariants stores its failure metadata on the inbound link (node.Inbound[0].FailedInvariants) rather than on the node's Process.FailedInvariants — see processor.go where the write happens. The failure-reporting branch in modelCheckSingleSpec only looked at the Process field, with these wrong consequences:
Now: if the node has no Process.FailedInvariants, check the inbound link. Print "Transition Invariant: " if found. Add a generic "Model checker failed (no failed-invariant metadata...)" fallback for model-checking mode so silence never happens.
Reproducer: a spec with a
transition assertionthat the model checker finds violating — previously misreported. Confirmed both modes now print the assertion name (TerminalStatesRemainTerminal in the test spec).