Skip to content

feat: use nix for image/package build, remove rust#951

Open
Pablu23 wants to merge 75 commits intomainfrom
feat-nix
Open

feat: use nix for image/package build, remove rust#951
Pablu23 wants to merge 75 commits intomainfrom
feat-nix

Conversation

@Pablu23
Copy link
Copy Markdown
Collaborator

@Pablu23 Pablu23 commented Mar 31, 2026

Description

  • Remove unused rust dependencies, remove setuptools_scm and use uv_build, add nix flake for container image, dev shell and application building

Assignee

  • The changes adhere to the contribution guidelines
  • I have performed a self-review of my code
  • My changes generate no new warnings (e.g. flake8/mypy/pytest/...) other than deprecations

Documentation

Code Quality

  • Patch test coverage > 95% and does not decrease
  • New code uses correct & specific type hints

How did you verify that the changes work in practice?

  • nix develop
  • nix build .#docker.python311 && docker load < result && docker run logprep:py3.11
  • nix build .#dist.python311 && ls result/

Reviewer


The rendered docs for this PR can be found here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (0fc524b) to head (e7228ba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files         218      218           
  Lines       14373    14373           
=======================================
  Hits        13828    13828           
  Misses        545      545           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


digest=$(docker inspect $tag | jq --raw-output ".[].Id")

# What happens with multiple tags?
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an answer for that question? :)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well not 100% but different tags are the same image producing the same digest, so using the latest is fine here (atleast thats what I observed) and it was the same before. But ill look into this some more

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of confirms that the same image should always have the same digest: distribution/distribution#1811 (comment)

Comment thread CHANGELOG.md
@Pablu23 Pablu23 requested a review from mhoff April 24, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants