Skip to content

Prevent invalid-regular expression syntax error in Safari < 16.4 #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tf wants to merge 1 commit into from
Closed

Prevent invalid-regular expression syntax error in Safari < 16.4 #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/proxy-cssom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export function installCSSOM() {
*/
function parseCSSMultiplication(str) {
let values = [];
const tokens = str.split(/(?<!\([^\)]*)([*])(?![^\(]*\))/);
const tokens = str.split(new RegExp('(?<!\\([^\\)]*)([*])(?![^\\(]*\\))'));
values.push(parseCSSDivision(tokens.shift()));
while (tokens.length) {
tokens.shift(); // Consume operator '*'
Expand All @@ -113,7 +113,7 @@ export function installCSSOM() {
*/
function parseCSSDivision(str) {
let values = [];
const tokens = str.split(/(?<!\([^\)]*)([/])(?![^\(]*\))/);
const tokens = str.split(new RegExp('(?<!\\([^\\)]*)([/])(?![^\\(]*\\))'));
values.push(parseCSSNumericValue(tokens.shift()));
while (tokens.length) {
tokens.shift(); // Consume operator '/'
Expand All @@ -129,7 +129,7 @@ export function installCSSOM() {
*/
function parseCSSMathSum(str) {
let values = [];
const tokens = str.split(/(?<!\([^\)]*)(\s[+-]\s)(?![^\(]*\))/);
const tokens = str.split(new RegExp('(?<!\\([^\\)]*)(\\s[+-]\\s)(?![^\\(]*\\))'));
values.push(parseCSSMultiplication(tokens.shift()));
while (tokens.length) {
let op = tokens.shift();
Expand Down
2 changes: 1 addition & 1 deletion src/scroll-timeline-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ function parseInset(value) {
// Parse string parts to
if (typeof value === 'string') {
// Split value into separate parts
const stringParts = value.split(/(?<!\([^\)]*)\s(?![^\(]*\))/);
const stringParts = value.split(new RegExp('(?<!\\([^\\)]*)\\s(?![^\\(]*\\))'));
parts = stringParts.map(str => {
if (str.trim() === 'auto') {
return 'auto';
Expand Down