fix: resolve clippy warnings#10
Merged
Merged
Conversation
- Collapse nested if statements with let-else chains - Use ? operator for Option handling - Use char array in split() instead of manual comparison - Add #[allow(clippy::too_many_arguments)] for functions with many parameters Fixes the following clippy lints: - collapsible-if (3 instances) - question-mark (1 instance) - manual-pattern-char-comparison (1 instance) - too-many-arguments (2 instances)
Owner
|
Thanks for taking care of this! |
Contributor
Author
|
Done! I've run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all clippy warnings when running
cargo clippy -- -D warnings.Changes
?operator for Option handling instead of let-elsesplit()instead of manual char comparison#[allow(clippy::too_many_arguments)]for functions with many parametersClippy Lints Fixed
collapsible-if(3 instances)question-mark(1 instance)manual-pattern-char-comparison(1 instance)too-many-arguments(2 instances - addressed with allow attributes)Verification
Now passes without any warnings.