Skip to content

chore(chart): reduce crd size by removing description#2106

Open
yashmehrotra wants to merge 1 commit intomainfrom
strip-crds
Open

chore(chart): reduce crd size by removing description#2106
yashmehrotra wants to merge 1 commit intomainfrom
strip-crds

Conversation

@yashmehrotra
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 15, 2026

Warning

Rate limit exceeded

@yashmehrotra has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 72581eaa-97de-42eb-933a-479937eaab50

📥 Commits

Reviewing files that changed from the base of the PR and between 44e7ac8 and 59b94b0.

📒 Files selected for processing (6)
  • Makefile
  • api/v1/zz_generated.deepcopy.go
  • chart/crds/configs.flanksource.com_scrapeconfigs.yaml
  • chart/crds/configs.flanksource.com_scrapeplugins.yaml
  • config/schemas/config_playwright.schema.json
  • config/schemas/scrape_config.schema.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch strip-crds
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch strip-crds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Benchstat

Base: 44e7ac8f65209afa69d9c01b5c47acde4e05aaa8
Head: 59b94b0b2d206b3804c459b7797131e3ffb28042

✅ No significant performance changes detected

Full benchstat output
goos: linux
goarch: amd64
pkg: github.com/flanksource/config-db/bench
cpu: AMD EPYC 7763 64-Core Processor                
                                         │ bench-base.txt │          bench-head.txt           │
                                         │     sec/op     │   sec/op     vs base              │
BenchSaveResultsSeed/N=1000-4                 631.9m ± 7%   633.6m ± 6%       ~ (p=0.818 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4      709.3m ± 3%   706.8m ± 2%       ~ (p=0.310 n=6)
BenchSaveResultsUpdateChanged/N=1000-4         1.155 ± 1%    1.155 ± 0%       ~ (p=0.937 n=6)
geomean                                       802.9m        802.6m       -0.03%

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      MB/s      │    MB/s     vs base                │
BenchSaveResultsSeed/N=1000-4                0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateUnchanged/N=1000-4     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateChanged/N=1000-4       0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                 ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      B/op      │     B/op      vs base              │
BenchSaveResultsSeed/N=1000-4                36.39Mi ± 0%   36.38Mi ± 0%       ~ (p=0.818 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     25.60Mi ± 0%   25.59Mi ± 0%       ~ (p=0.699 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       74.87Mi ± 0%   74.90Mi ± 0%       ~ (p=0.699 n=6)
geomean                                      41.16Mi        41.16Mi       +0.00%

                                         │ bench-base.txt │          bench-head.txt           │
                                         │   allocs/op    │  allocs/op   vs base              │
BenchSaveResultsSeed/N=1000-4                 475.1k ± 0%   475.1k ± 0%       ~ (p=0.457 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4      317.0k ± 0%   317.1k ± 0%       ~ (p=0.613 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        910.6k ± 0%   910.7k ± 0%       ~ (p=0.290 n=6)
geomean                                       515.7k        515.7k       +0.00%

@yashmehrotra yashmehrotra requested a review from moshloop April 16, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant