Skip to content

Fix RLS disable for view tables#1736

Draft
adityathebe wants to merge 1 commit intomainfrom
fix/view-rls-removal
Draft

Fix RLS disable for view tables#1736
adityathebe wants to merge 1 commit intomainfrom
fix/view-rls-removal

Conversation

@adityathebe
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/view-rls-removal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 20, 2026

Benchstat

Base: 108ab97c0669f35f32392e39b661dab52acedeff
Head: ab21a9e45836755d1a815ad89a2ec24b3e0f059e

goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 7763 64-Core Processor                
                                                │ bench-base.txt │          bench-head.txt           │
                                                │     sec/op     │   sec/op     vs base              │
Main/Sample-15000/catalog_changes/Without_RLS-4      5.123m ± 0%   5.145m ± 0%  +0.44% (p=0.015 n=6)
Main/Sample-15000/catalog_changes/With_RLS-4         127.8m ± 0%   128.2m ± 0%  +0.28% (p=0.015 n=6)
Main/Sample-15000/config_changes/Without_RLS-4       5.072m ± 1%   5.132m ± 1%  +1.17% (p=0.004 n=6)
Main/Sample-15000/config_changes/With_RLS-4          129.6m ± 0%   127.9m ± 0%  -1.30% (p=0.002 n=6)
Main/Sample-15000/config_detail/Without_RLS-4        3.812m ± 2%   3.822m ± 1%       ~ (p=0.240 n=6)
Main/Sample-15000/config_detail/With_RLS-4           125.9m ± 0%   124.7m ± 0%  -0.96% (p=0.002 n=6)
Main/Sample-15000/config_names/Without_RLS-4         12.51m ± 1%   12.74m ± 1%  +1.86% (p=0.002 n=6)
Main/Sample-15000/config_names/With_RLS-4            125.4m ± 2%   125.4m ± 1%       ~ (p=0.937 n=6)
Main/Sample-15000/config_summary/Without_RLS-4       59.80m ± 3%   64.03m ± 2%  +7.07% (p=0.002 n=6)
Main/Sample-15000/config_summary/With_RLS-4          733.1m ± 1%   740.9m ± 1%  +1.07% (p=0.002 n=6)
Main/Sample-15000/configs/Without_RLS-4              7.048m ± 1%   7.315m ± 3%  +3.79% (p=0.002 n=6)
Main/Sample-15000/configs/With_RLS-4                 122.6m ± 0%   129.7m ± 1%  +5.77% (p=0.002 n=6)
Main/Sample-15000/analysis_types/Without_RLS-4       3.792m ± 1%   3.797m ± 0%       ~ (p=0.394 n=6)
Main/Sample-15000/analysis_types/With_RLS-4          3.915m ± 1%   3.814m ± 1%  -2.57% (p=0.002 n=6)
Main/Sample-15000/analyzer_types/Without_RLS-4       3.661m ± 1%   3.711m ± 1%  +1.36% (p=0.015 n=6)
Main/Sample-15000/analyzer_types/With_RLS-4          3.683m ± 1%   3.738m ± 6%  +1.52% (p=0.002 n=6)
Main/Sample-15000/change_types/Without_RLS-4         5.150m ± 0%   5.337m ± 4%  +3.63% (p=0.002 n=6)
Main/Sample-15000/change_types/With_RLS-4            5.181m ± 1%   5.640m ± 3%  +8.86% (p=0.002 n=6)
Main/Sample-15000/config_classes/Without_RLS-4       3.231m ± 1%   3.513m ± 9%  +8.71% (p=0.004 n=6)
Main/Sample-15000/config_classes/With_RLS-4          123.8m ± 0%   126.3m ± 4%  +1.96% (p=0.002 n=6)
Main/Sample-15000/config_types/Without_RLS-4         3.875m ± 1%   3.985m ± 3%  +2.85% (p=0.015 n=6)
Main/Sample-15000/config_types/With_RLS-4            123.9m ± 1%   125.3m ± 1%  +1.11% (p=0.002 n=6)
geomean                                              18.94m        19.33m       +2.09%

@adityathebe adityathebe force-pushed the fix/view-rls-removal branch 3 times, most recently from 1d0fc66 to 8c857aa Compare January 20, 2026 09:27
@adityathebe adityathebe marked this pull request as draft January 20, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant