Skip to content

fix: least privilege permission#1819

Draft
adityathebe wants to merge 1 commit intomainfrom
fix/strict-permission
Draft

fix: least privilege permission#1819
adityathebe wants to merge 1 commit intomainfrom
fix/strict-permission

Conversation

@adityathebe
Copy link
Copy Markdown
Member

A year old branch. Creating a PR for now

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

Benchstat

Base: 2c2a57c19bc915c8a90d11ed958dddf64688a291
Head: 1e80062758f1039d91821eb993b5028153774b2c

goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 7763 64-Core Processor                
                                                       │ bench-base.txt │           bench-head.txt           │
                                                       │     sec/op     │    sec/op     vs base              │
InsertionForRowsWithAliases/external_users.aliases-4       566.5µ ± 14%   572.6µ ± 10%       ~ (p=0.485 n=6)
InsertionForRowsWithAliases/config_items.external_id-4     1.104m ± 11%   1.106m ± 10%       ~ (p=0.937 n=6)
RLS/Sample-15000/catalog_changes/Without_RLS-4             5.247m ±  3%   5.434m ±  1%  +3.57% (p=0.009 n=6)
RLS/Sample-15000/catalog_changes/With_RLS-4                127.8m ±  0%   130.3m ±  1%  +1.95% (p=0.002 n=6)
RLS/Sample-15000/config_changes/Without_RLS-4              5.267m ±  4%   5.380m ±  6%  +2.14% (p=0.041 n=6)
RLS/Sample-15000/config_changes/With_RLS-4                 129.4m ±  3%   128.7m ±  1%  -0.49% (p=0.026 n=6)
RLS/Sample-15000/config_detail/Without_RLS-4               3.947m ±  0%   4.012m ±  3%  +1.67% (p=0.026 n=6)
RLS/Sample-15000/config_detail/With_RLS-4                  123.8m ±  0%   126.9m ±  1%  +2.51% (p=0.002 n=6)
RLS/Sample-15000/config_names/Without_RLS-4                13.17m ±  2%   13.18m ±  1%       ~ (p=0.937 n=6)
RLS/Sample-15000/config_names/With_RLS-4                   125.0m ±  1%   127.6m ±  1%  +2.02% (p=0.002 n=6)
RLS/Sample-15000/config_summary/Without_RLS-4              93.06m ±  2%   94.92m ±  1%       ~ (p=0.093 n=6)
RLS/Sample-15000/config_summary/With_RLS-4                 731.2m ±  1%   738.8m ±  0%  +1.04% (p=0.015 n=6)
RLS/Sample-15000/configs/Without_RLS-4                     7.443m ±  2%   7.501m ±  2%       ~ (p=0.485 n=6)
RLS/Sample-15000/configs/With_RLS-4                        124.1m ±  0%   128.8m ±  0%  +3.77% (p=0.002 n=6)
RLS/Sample-15000/analysis_types/Without_RLS-4              3.919m ±  1%   3.969m ±  1%  +1.29% (p=0.026 n=6)
RLS/Sample-15000/analysis_types/With_RLS-4                 3.974m ±  4%   3.902m ±  1%  -1.79% (p=0.002 n=6)
RLS/Sample-15000/analyzer_types/Without_RLS-4              3.753m ±  2%   3.722m ±  1%  -0.83% (p=0.026 n=6)
RLS/Sample-15000/analyzer_types/With_RLS-4                 3.789m ±  2%   3.812m ±  1%       ~ (p=0.240 n=6)
RLS/Sample-15000/change_types/Without_RLS-4                5.366m ±  1%   5.298m ±  1%  -1.26% (p=0.015 n=6)
RLS/Sample-15000/change_types/With_RLS-4                   5.401m ±  1%   5.355m ±  5%       ~ (p=0.394 n=6)
RLS/Sample-15000/config_classes/Without_RLS-4              3.357m ±  1%   3.397m ±  2%       ~ (p=0.065 n=6)
RLS/Sample-15000/config_classes/With_RLS-4                 124.6m ±  2%   123.5m ±  1%  -0.90% (p=0.026 n=6)
RLS/Sample-15000/config_types/Without_RLS-4                3.970m ±  3%   4.108m ±  2%  +3.47% (p=0.002 n=6)
RLS/Sample-15000/config_types/With_RLS-4                   128.8m ±  0%   123.8m ±  1%  -3.82% (p=0.002 n=6)
geomean                                                    15.10m         15.22m        +0.79%

                                                       │ bench-base.txt │           bench-head.txt           │
                                                       │      B/op      │     B/op      vs base              │
InsertionForRowsWithAliases/external_users.aliases-4       15.30Ki ± 0%   15.31Ki ± 0%       ~ (p=0.167 n=6)
InsertionForRowsWithAliases/config_items.external_id-4     22.89Ki ± 0%   22.90Ki ± 0%       ~ (p=0.377 n=6)
geomean                                                    18.71Ki        18.73Ki       +0.07%

                                                       │ bench-base.txt │           bench-head.txt           │
                                                       │   allocs/op    │ allocs/op   vs base                │
InsertionForRowsWithAliases/external_users.aliases-4         238.0 ± 0%   238.0 ± 0%       ~ (p=1.000 n=6) ¹
InsertionForRowsWithAliases/config_items.external_id-4       294.0 ± 0%   294.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                                      264.5        264.5       +0.00%
¹ all samples are equal

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 10, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c016dd5f-3e72-4f06-bc68-66597a0fb181

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/strict-permission

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant