Ignore unsupported column filters for resource types that don't support them#1847
Draft
Ignore unsupported column filters for resource types that don't support them#1847
Conversation
|
|
…e applies Co-authored-by: moshloop <1489660+moshloop@users.noreply.github.com> Agent-Logs-Url: https://github.com/flanksource/duty/sessions/9f9b0658-96ce-44ab-be44-b62e8ba4f07c
Co-authored-by: moshloop <1489660+moshloop@users.noreply.github.com> Agent-Logs-Url: https://github.com/flanksource/duty/sessions/9f9b0658-96ce-44ab-be44-b62e8ba4f07c
Copilot
AI
changed the title
[WIP] Fix query search to ignore invalid resource types
Ignore unsupported column filters for resource types that don't support them
Mar 23, 2026
Benchstat (Other)Base: 📊 1 minor regression(s) (all within 5% threshold)
✅ 2 improvement(s)
Full benchstat output |
Benchstat (RLS)Base: 📊 4 minor regression(s) (all within 5% threshold)
✅ 9 improvement(s)
Full benchstat output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching across multiple resource types with a filter that only applies to some (e.g.,
#canary #config type=pod), the entire query failed becausetypeis not a column on thecanariestable.Changes
ErrColumnNotSupported) added toquery/models.goso callers can distinguish "column doesn't exist on this table" from real errorsqm.Apply: wraps the unsupported column error with the sentinel instead of a plainfmt.ErrorfqueryTableWithResourceSelectors/QueryTableColumnsWithResourceSelectors: skip (return empty results) for any selector that producesErrColumnNotSupportedrather than propagating the errorOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.