chore: use go 1.26.x in github workflows#1894
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 16 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benchstat (RLS)Base:
|
| Benchmark | Base | Head | Change | p-value |
|---|---|---|---|---|
RLS/Sample-15000/change_types/Without_RLS-4 |
5.281m | 5.586m | +5.78% 🔴 | 0.002 |
RLS/Sample-15000/analyzer_types/With_RLS-4 |
3.761m | 3.850m | +2.36% | 0.002 |
RLS/Sample-15000/config_types/With_RLS-4 |
125.9m | 126.9m | +0.83% | 0.009 |
RLS/Sample-15000/config_changes/Without_RLS-4 |
5.204m | 5.240m | +0.68% | 0.015 |
RLS/Sample-15000/config_classes/With_RLS-4 |
123.7m | 124.0m | +0.21% | 0.015 |
✅ 7 improvement(s)
| Benchmark | Base | Head | Change | p-value |
|---|---|---|---|---|
RLS/Sample-15000/change_types/With_RLS-4 |
5.415m | 5.256m | -2.92% | 0.002 |
RLS/Sample-15000/analyzer_types/Without_RLS-4 |
3.836m | 3.746m | -2.33% | 0.002 |
RLS/Sample-15000/configs/With_RLS-4 |
124.7m | 122.4m | -1.85% | 0.002 |
RLS/Sample-15000/configs/Without_RLS-4 |
7.212m | 7.110m | -1.42% | 0.004 |
RLS/Sample-15000/config_names/With_RLS-4 |
126.3m | 124.8m | -1.19% | 0.041 |
RLS/Sample-15000/analysis_types/Without_RLS-4 |
3.920m | 3.893m | -0.71% | 0.009 |
RLS/Sample-15000/catalog_changes/With_RLS-4 |
129.1m | 128.3m | -0.64% | 0.026 |
Failed: 1 benchmark(s) regressed by more than 5%:
RLS/Sample-15000/change_types/Without_RLS-4: 5.281m -> 5.586m (+5.78%)
Full benchstat output
goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 7763 64-Core Processor
│ bench-base.txt │ bench-head.txt │
│ sec/op │ sec/op vs base │
RLS/Sample-15000/catalog_changes/Without_RLS-4 5.312m ± 2% 5.260m ± 2% ~ (p=0.310 n=6)
RLS/Sample-15000/catalog_changes/With_RLS-4 129.1m ± 0% 128.3m ± 1% -0.64% (p=0.026 n=6)
RLS/Sample-15000/config_changes/Without_RLS-4 5.204m ± 0% 5.240m ± 2% +0.68% (p=0.015 n=6)
RLS/Sample-15000/config_changes/With_RLS-4 128.2m ± 1% 128.2m ± 1% ~ (p=0.818 n=6)
RLS/Sample-15000/config_detail/Without_RLS-4 3.923m ± 1% 3.903m ± 1% ~ (p=0.240 n=6)
RLS/Sample-15000/config_detail/With_RLS-4 125.3m ± 0% 125.2m ± 1% ~ (p=0.394 n=6)
RLS/Sample-15000/config_names/Without_RLS-4 12.67m ± 0% 12.66m ± 1% ~ (p=0.818 n=6)
RLS/Sample-15000/config_names/With_RLS-4 126.3m ± 2% 124.8m ± 2% -1.19% (p=0.041 n=6)
RLS/Sample-15000/config_summary/Without_RLS-4 61.13m ± 1% 61.81m ± 2% ~ (p=0.065 n=6)
RLS/Sample-15000/config_summary/With_RLS-4 744.5m ± 1% 741.9m ± 1% ~ (p=0.485 n=6)
RLS/Sample-15000/configs/Without_RLS-4 7.212m ± 4% 7.110m ± 1% -1.42% (p=0.004 n=6)
RLS/Sample-15000/configs/With_RLS-4 124.7m ± 1% 122.4m ± 0% -1.85% (p=0.002 n=6)
RLS/Sample-15000/analysis_types/Without_RLS-4 3.920m ± 1% 3.893m ± 1% -0.71% (p=0.009 n=6)
RLS/Sample-15000/analysis_types/With_RLS-4 3.943m ± 1% 3.910m ± 4% ~ (p=0.065 n=6)
RLS/Sample-15000/analyzer_types/Without_RLS-4 3.836m ± 0% 3.746m ± 0% -2.33% (p=0.002 n=6)
RLS/Sample-15000/analyzer_types/With_RLS-4 3.761m ± 1% 3.850m ± 2% +2.36% (p=0.002 n=6)
RLS/Sample-15000/change_types/Without_RLS-4 5.281m ± 1% 5.586m ± 1% +5.78% (p=0.002 n=6)
RLS/Sample-15000/change_types/With_RLS-4 5.415m ± 3% 5.256m ± 0% -2.92% (p=0.002 n=6)
RLS/Sample-15000/config_classes/Without_RLS-4 3.302m ± 2% 3.299m ± 1% ~ (p=0.485 n=6)
RLS/Sample-15000/config_classes/With_RLS-4 123.7m ± 0% 124.0m ± 0% +0.21% (p=0.015 n=6)
RLS/Sample-15000/config_types/Without_RLS-4 3.911m ± 2% 3.897m ± 1% ~ (p=0.394 n=6)
RLS/Sample-15000/config_types/With_RLS-4 125.9m ± 0% 126.9m ± 2% +0.83% (p=0.009 n=6)
geomean 19.29m 19.26m -0.17%
Benchstat (Other)Base:
|
| Benchmark | Base | Head | Change | p-value |
|---|---|---|---|---|
InsertionForRowsWithAliases/external_users.aliases-4 |
2.182m | 6.345m | +190.74% 🔴 | 0.015 |
✅ 2 improvement(s)
| Benchmark | Base | Head | Change | p-value |
|---|---|---|---|---|
ResourceSelectorQueryBuild/tags-4 |
13.28µ | 13.04µ | -1.77% | 0.002 |
ResourceSelectorQueryBuild/name_and_type-4 |
47.30µ | 46.84µ | -0.99% | 0.026 |
Failed: 1 benchmark(s) regressed by more than 5%:
InsertionForRowsWithAliases/external_users.aliases-4: 2.182m -> 6.345m (+190.74%)
Full benchstat output
goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 9V74 80-Core Processor
│ bench-base.txt │ bench-head.txt │
│ sec/op │ sec/op vs base │
InsertionForRowsWithAliases/external_users.aliases-4 2.182m ± 88% 6.345m ± 158% +190.74% (p=0.015 n=6)
InsertionForRowsWithAliases/config_items.external_id-4 3.013m ± 58% 3.348m ± 295% ~ (p=0.485 n=6)
ResourceSelectorConfigs/name-4 155.3µ ± 6% 151.4µ ± 6% ~ (p=0.589 n=6)
ResourceSelectorConfigs/name_and_type-4 168.0µ ± 4% 169.6µ ± 3% ~ (p=0.310 n=6)
ResourceSelectorConfigs/tags-4 22.34m ± 5% 22.33m ± 6% ~ (p=0.699 n=6)
ResourceSelectorQueryBuild/name-4 32.21µ ± 3% 32.26µ ± 1% ~ (p=0.589 n=6)
ResourceSelectorQueryBuild/name_and_type-4 47.30µ ± 18% 46.84µ ± 1% -0.99% (p=0.026 n=6)
ResourceSelectorQueryBuild/tags-4 13.28µ ± 12% 13.04µ ± 1% -1.77% (p=0.002 n=6)
geomean 306.3µ 352.8µ +15.17%
1 participant
No description provided.