feat: Notification watchdog schedule

[adityathebe]

No description provided.

[coderabbitai]

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 54 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 54 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b0b9b6fc-2199-4b8b-9ed2-63ed81f5eb74

📥 Commits

Reviewing files that changed from the base of the PR and between 8bf433e and a58358c.

📒 Files selected for processing (2)

• models/notifications.go
• schema/notifications.hcl

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/use-cron-schedule-notification-watchdog

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/use-cron-schedule-notification-watchdog

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Benchstat (RLS)

Base: 8bf433eed13eef80c1820f57b7cf7f51ca790e1c
Head: a58358cf4cc0403e74ba05ec191099b8c8b213c4

📊 2 minor regression(s) (all within 5% threshold)

Benchmark	Base	Head	Change	p-value
RLS/Sample-15000/analysis_types/With_RLS-4	3.414m	3.479m	+1.90%	0.009
RLS/Sample-15000/configs/With_RLS-4	109.1m	110.3m	+1.09%	0.009

✅ 6 improvement(s)

Benchmark	Base	Head	Change	p-value
RLS/Sample-15000/config_detail/Without_RLS-4	3.574m	3.451m	-3.45%	0.041
RLS/Sample-15000/config_classes/Without_RLS-4	2.944m	2.850m	-3.22%	0.002
RLS/Sample-15000/config_changes/With_RLS-4	115.6m	112.5m	-2.69%	0.002
RLS/Sample-15000/config_summary/Without_RLS-4	56.93m	55.46m	-2.57%	0.002
RLS/Sample-15000/config_names/Without_RLS-4	12.19m	12.02m	-1.37%	0.041
RLS/Sample-15000/config_types/With_RLS-4	110.0m	109.1m	-0.78%	0.009

Full benchstat output

goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 9V74 80-Core Processor                
                                               │ bench-base.txt │          bench-head.txt           │
                                               │     sec/op     │   sec/op     vs base              │
RLS/Sample-15000/catalog_changes/Without_RLS-4      4.630m ± 2%   4.565m ± 2%       ~ (p=0.065 n=6)
RLS/Sample-15000/catalog_changes/With_RLS-4         113.2m ± 1%   112.6m ± 1%       ~ (p=0.093 n=6)
RLS/Sample-15000/config_changes/Without_RLS-4       4.552m ± 2%   4.567m ± 2%       ~ (p=0.818 n=6)
RLS/Sample-15000/config_changes/With_RLS-4          115.6m ± 1%   112.5m ± 1%  -2.69% (p=0.002 n=6)
RLS/Sample-15000/config_detail/Without_RLS-4        3.574m ± 1%   3.451m ± 4%  -3.45% (p=0.041 n=6)
RLS/Sample-15000/config_detail/With_RLS-4           108.9m ± 2%   109.4m ± 2%       ~ (p=0.180 n=6)
RLS/Sample-15000/config_names/Without_RLS-4         12.19m ± 1%   12.02m ± 1%  -1.37% (p=0.041 n=6)
RLS/Sample-15000/config_names/With_RLS-4            109.1m ± 0%   108.8m ± 2%       ~ (p=0.394 n=6)
RLS/Sample-15000/config_summary/Without_RLS-4       56.93m ± 2%   55.46m ± 1%  -2.57% (p=0.002 n=6)
RLS/Sample-15000/config_summary/With_RLS-4          643.2m ± 1%   643.2m ± 0%       ~ (p=0.937 n=6)
RLS/Sample-15000/configs/Without_RLS-4              6.731m ± 5%   6.521m ± 6%       ~ (p=0.310 n=6)
RLS/Sample-15000/configs/With_RLS-4                 109.1m ± 1%   110.3m ± 1%  +1.09% (p=0.009 n=6)
RLS/Sample-15000/analysis_types/Without_RLS-4       3.438m ± 2%   3.437m ± 1%       ~ (p=0.485 n=6)
RLS/Sample-15000/analysis_types/With_RLS-4          3.414m ± 2%   3.479m ± 3%  +1.90% (p=0.009 n=6)
RLS/Sample-15000/analyzer_types/Without_RLS-4       3.291m ± 1%   3.294m ± 2%       ~ (p=0.818 n=6)
RLS/Sample-15000/analyzer_types/With_RLS-4          3.303m ± 2%   3.386m ± 4%       ~ (p=0.132 n=6)
RLS/Sample-15000/change_types/Without_RLS-4         4.578m ± 3%   4.599m ± 2%       ~ (p=0.937 n=6)
RLS/Sample-15000/change_types/With_RLS-4            4.574m ± 3%   4.661m ± 2%       ~ (p=0.132 n=6)
RLS/Sample-15000/config_classes/Without_RLS-4       2.944m ± 4%   2.850m ± 2%  -3.22% (p=0.002 n=6)
RLS/Sample-15000/config_classes/With_RLS-4          109.9m ± 2%   109.4m ± 1%       ~ (p=0.180 n=6)
RLS/Sample-15000/config_types/Without_RLS-4         3.551m ± 2%   3.531m ± 3%       ~ (p=0.485 n=6)
RLS/Sample-15000/config_types/With_RLS-4            110.0m ± 0%   109.1m ± 1%  -0.78% (p=0.009 n=6)
geomean                                             17.08m        16.98m       -0.55%

[github-actions]

Benchstat (Other)

Base: 8bf433eed13eef80c1820f57b7cf7f51ca790e1c
Head: a58358cf4cc0403e74ba05ec191099b8c8b213c4

✅ No significant performance changes detected

Full benchstat output

goos: linux
goarch: amd64
pkg: github.com/flanksource/duty/bench
cpu: AMD EPYC 9V74 80-Core Processor                
                                                       │ bench-base.txt │           bench-head.txt           │
                                                       │     sec/op     │    sec/op     vs base              │
InsertionForRowsWithAliases/external_users.aliases-4       526.9µ ±  3%   521.7µ ±  8%       ~ (p=0.937 n=6)
InsertionForRowsWithAliases/config_items.external_id-4     1.039m ± 11%   1.032m ± 13%       ~ (p=0.818 n=6)
ResourceSelectorConfigs/name-4                             191.6µ ±  2%   191.3µ ±  6%       ~ (p=0.937 n=6)
ResourceSelectorConfigs/name_and_type-4                    212.9µ ±  8%   204.5µ ±  5%       ~ (p=0.394 n=6)
ResourceSelectorConfigs/tags-4                             57.27m ± 49%   55.64m ± 53%       ~ (p=0.937 n=6)
ResourceSelectorQueryBuild/name-4                          40.08µ ±  1%   39.76µ ±  1%       ~ (p=0.065 n=6)
ResourceSelectorQueryBuild/name_and_type-4                 58.63µ ±  4%   58.41µ ±  1%       ~ (p=0.699 n=6)
ResourceSelectorQueryBuild/tags-4                          16.05µ ±  0%   15.87µ ±  7%       ~ (p=0.394 n=6)
geomean                                                    288.7µ         284.7µ        -1.37%